Comment 1 for bug 592295

Revision history for this message
Bryan Wu (cooloney) wrote :

After grepping the OMAP4 kernel, I found some code was commented in the driver:

drivers/video/omap2/dss/dispc.c
----
        if (errors & DISPC_IRQ_SYNC_LOST_DIGIT) {

        DSSERR("SYNC_LOST_DIGIT\n");
/*commenting below code as with 1080P Decode we see a sync lost digit for
first frame as it takes long time to decode but it later recovers*/
#if 0
                struct omap_overlay_manager *manager = NULL;
                bool enable = false;

                DSSERR("SYNC_LOST_DIGIT, disabling TV\n");

                for (i = 0; i < omap_dss_get_num_overlay_managers(); ++i) {
                        struct omap_overlay_manager *mgr;
                        mgr = omap_dss_get_overlay_manager(i);

                        if (mgr->id == OMAP_DSS_CHANNEL_DIGIT) {
                                manager = mgr;
                                enable = mgr->device->state ==
                                                OMAP_DSS_DISPLAY_ACTIVE;
                                mgr->device->driver->disable(mgr->device);
                                break;
                        }

                }

                if (manager) {
                        struct omap_dss_device *dssdev = manager->device;
                        for (i = 0; i < omap_dss_get_num_overlays(); ++i) {
                                struct omap_overlay *ovl;
                                ovl = omap_dss_get_overlay(i);

                                if (!(ovl->caps & OMAP_DSS_OVL_CAP_DISPC))
                                        continue;

                                if (ovl->id != 0 && ovl->manager == manager)
                                        dispc_enable_plane(ovl->id, 0);
                        }

                        dispc_go(manager->id);
                        mdelay(50);
                        if (enable)
                                dssdev->driver->enable(dssdev);
                }
#endif
        }
----

I am not sure about that.
-Bryan