Jaromír Cápík <email address hidden> :
[...]
> Actually, I got the same idea 2 days ago,
> but then I got on my mind the following question:
> What happens with the WOL and Speed/Duplex
> settings when You reset the chip?
Yeah, yeah, I confused 1 << 3 and CmdReset. Call me an idiot.
I have read again the whole thread. Slowly.
The reports show that the receiver needs to be enabled for
some devices (especially amongst the 8168) to be able to WoL.
You are completely right on that point. I'll take care of it.
Please wait until tomorrow so that I add a Rx stop descriptor
to prevent any corruption due to Rx DMA: afaik nothing ensures
that RDSAR is correctly set when the receiver is enabled again
in rtl_shutdown (especially if the device is down before
rtl_shutdown is called).
As a last question, is it right to assume that:
1. you can not WoL your 8168 if it is ifconfiged down before
being suspended (i.e. whatever the shutdown path, it is
not used)
2. the 8169 does not care
Jaromír Cápík <email address hidden> :
[...]
> Actually, I got the same idea 2 days ago,
> but then I got on my mind the following question:
> What happens with the WOL and Speed/Duplex
> settings when You reset the chip?
Yeah, yeah, I confused 1 << 3 and CmdReset. Call me an idiot.
I have read again the whole thread. Slowly.
The reports show that the receiver needs to be enabled for
some devices (especially amongst the 8168) to be able to WoL.
You are completely right on that point. I'll take care of it.
Please wait until tomorrow so that I add a Rx stop descriptor
to prevent any corruption due to Rx DMA: afaik nothing ensures
that RDSAR is correctly set when the receiver is enabled again
in rtl_shutdown (especially if the device is down before
rtl_shutdown is called).
As a last question, is it right to assume that:
1. you can not WoL your 8168 if it is ifconfiged down before
being suspended (i.e. whatever the shutdown path, it is
not used)
2. the 8169 does not care
Thanks for your patient testing.