Comment 2 for bug 1858658

Revision history for this message
Juerg Haefliger (juergh) wrote :

Probably due to:

commit c5d736105ab2d84096e35ecc71a265345d66a25c
Author: Trent Piepho <email address hidden>
Date: Thu Sep 20 19:18:34 2018 +0000

    spi: spidev: Fix OF tree warning logic

    BugLink: https://bugs.launchpad.net/bugs/1854216

    [ Upstream commit 605b3bec73cbd74b4ac937b580cd0b47d1300484 ]

    spidev will make a big fuss if a device tree node binds a device by
    using "spidev" as the node's compatible property.

    However, the logic for this isn't looking for "spidev" in the
    compatible, but rather checking that the device is NOT compatible with
    spidev's list of devices.

    This causes a false positive if a device not named "rohm,dh2228fv", etc.
    binds to spidev, even if a means other than putting "spidev" in the
    device tree was used. E.g., the sysfs driver_override attribute.

    Signed-off-by: Trent Piepho <email address hidden>
    Reviewed-by: Jan Kundrát <email address hidden>
    Tested-by: Jan Kundrát <email address hidden>
    Reviewed-by: Geert Uytterhoeven <email address hidden>
    Signed-off-by: Mark Brown <email address hidden>
    Signed-off-by: Sasha Levin <email address hidden>
    Signed-off-by: Kamal Mostafa <email address hidden>
    Signed-off-by: Khalid Elmously <email address hidden>