Comment 0 for bug 1953540

Revision history for this message
Alex Hung (alexhung) wrote :

[Impact]

On some platform designs the the power button wakeup from s0i3 doesn't work even with the existing changes to IRQ handling for the GPIO controller.

In these designs the ACPI SCI and GPIO controller share an IRQ. Due to the the way the s2idle loop handles the IRQ for the ACPI SCI the GPIO controller driver doesn't get a chance to wake the system in this circumstance.

[Fix]
To fix this rework the existing IRQ handler function to function as a checker and an IRQ handler depending on the calling arguments.

The patches were cherry-picked from 5.16rc3.

[Test]
This is requested by AMD. The test was done on two systems L15 AMD Gen2 and P14s AMD Gen2 and both can be waken up by power button

[Where problems could occur]
Risk is low. This only affects AMD platforms with s0i3 enabled. Suspends/resumes are not affect.