Comment 2 for bug 1634892

Revision history for this message
Thomas Copeland (copeland-tj) wrote :

I've bisected Ubuntu-3.13.0-96.143 to Ubuntu3.13.0-97.144 and it looks like 7b82096b0ebc9bf487b390fe970d66ffa5a5774e introduced the problem.

thomasco@dev:/storage/ubuntu-trusty (7b82096...|BISECTING) $ git bisect bad
7b82096b0ebc9bf487b390fe970d66ffa5a5774e is the first bad commit
commit 7b82096b0ebc9bf487b390fe970d66ffa5a5774e
Author: Jiri Pirko <email address hidden>
Date: Sat Dec 7 19:26:56 2013 +0100

    neigh: restore old behaviour of default parms values

    commit 1d4c8c29841b9991cdf3c7cc4ba7f96a94f104ca upstream.

    Previously inet devices were only constructed when addresses are added.
    Therefore the default neigh parms values they get are the ones at the
    time of these operations.

    Now that we're creating inet devices earlier, this changes the behaviour
    of default neigh parms values in an incompatible way (see bug #8519).

    This patch creates a compromise by setting the default values at the
    same point as before but only for those that have not been explicitly
    set by the user since the inet device's creation.

    Introduced by:
    commit 8030f54499925d073a88c09f30d5d844fb1b3190
    Author: Herbert Xu <email address hidden>
    Date: Thu Feb 22 01:53:47 2007 +0900

        [IPV4] devinet: Register inetdev earlier.

    Signed-off-by: Jiri Pirko <email address hidden>
    Signed-off-by: David S. Miller <email address hidden>
    BugLink: https://bugs.launchpad.net/bugs/994931
    Signed-off-by: Kamal Mostafa <email address hidden>
    Acked-by: Tim Gardner <email address hidden>
    Acked-by: Brad Figg <email address hidden>

:040000 040000 b95e2490d8d94ffb3c4b5818b0ca05e2cdff17d2 7296def1ea38ae1c46ec1a6ba4df3d26fe568545 M include
:040000 040000 e78478aead22c4947b2b4f816a244272613fdc08 12e3e33ddae9c141ae77b6eb471ab5b9d5214db8 M net

thomasco@dev:/storage/ubuntu-trusty (7b82096...|BISECTING) $ git bisect log
# bad: [002556d23100065c43d60bfdab94fedf0a30cca6] UBUNTU: Ubuntu-3.13.0-97.144
# good: [d8590fec6790ab84c56f483bef6ce0caf71a40af] UBUNTU: Ubuntu-3.13.0-96.143
git bisect start 'Ubuntu-3.13.0-97.144' 'Ubuntu-3.13.0-96.143'
# good: [e5e45738175efd66844287ddcdf75e0e756fbd52] PCI: Add Netronome vendor and device IDs
git bisect good e5e45738175efd66844287ddcdf75e0e756fbd52
# good: [a70a25682944ac342dae0add0a4bb4c443e93411] Revert "UBUNTU: SAUCE: (no-up) ipv6: make the net.ipv6.conf.all.use_tempaddr sysctl propagate to interface settings"
git bisect good a70a25682944ac342dae0add0a4bb4c443e93411
# good: [6235189019f6136cb28646c2e637b76217a8d837] neigh: use tbl->family to distinguish ipv4 from ipv6
git bisect good 6235189019f6136cb28646c2e637b76217a8d837
# bad: [68a4a771678dd24d5eb30801d43412afb48723f5] neigh: ipv6: respect default values set before an address is assigned to device
git bisect bad 68a4a771678dd24d5eb30801d43412afb48723f5
# bad: [7b82096b0ebc9bf487b390fe970d66ffa5a5774e] neigh: restore old behaviour of default parms values
git bisect bad 7b82096b0ebc9bf487b390fe970d66ffa5a5774e
# first bad commit: [7b82096b0ebc9bf487b390fe970d66ffa5a5774e] neigh: restore old behaviour of default parms values