Comment 26 for bug 720055

Revision history for this message
John Rigby (jcrigby) wrote :

From irc conversation with sakoman CONFIG_OMAP2_DSS_SDI should not be turned on for a board without an sdi display. Here is the very informative discussion:

<sakoman__> jcrigby: the "proper" fix for the vdds_sdi regulator issue is to unset CONFIG_OMAP2_DSS_SDI in your defconfig
<sakoman__> none of the indicated boards use an sdi display, so it makes no sense to set that!
<sakoman__> so I won't be submitting a vdds_sdi regulator patch for Overo (it wouldn't be accepted anyway due to the above!)
<lool> sakoman__: What happens if you turn on CONFIG_OMAP2_DSS_SDI for another board in the same kernel?
<sakoman__> you will likely get a regulator error when compiling boards that don't have sdi displays
<sakoman__> lool: I would be surprised if you have a board with an sdi display
<sakoman__> lool: N900 is the only board that I know of which uses sdi
<sakoman__> tomba has already stated that he will not accept patches adding sdi regulators for boards without sdi displays
<sakoman__> it is just the wrong way to fix the issue
<lool> sakoman__: Turns out that some people are enabling N900 in Ubuntu, and I was wondering whether we should enable it in our kernels!
<lool> sakoman__: Can we make the effect of CONFIG_OMAP2_DSS_SDI more runtime than it is right now?
<sakoman__> well, if you do, then the proper fix would be in sdi.c, not in board files
<lool> sakoman__: I believe you :-)
<lool> Or rather, I'll take your word for it
<sakoman__> that is where the real issue is in that it requests the regulator always, not just when an sdi display is used

so the proper fix is what I thought was just a workaround. Turn off CONFIG_OMAP2_DSS_SDI.