Comment 7 for bug 1867813

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

I gave this a review from the MIR POV under the constraint that this would likely be handled similar to the other firmware/microcode packages.

It is important to note that just looking at the source this would be a clear nack:
- precompiled kernel modules in ./modules
- precompiled shared objects in ./opt/vc
- many unsused source in ./hadfp/opt/
- GPU bins for 1001 drivers
...

This is Ubuntu only anyway and we use the code from https://github.com/raspberrypi/firmware/releases

If we could define a trivial but very effective source path filter and repackage this into a -dfsg like tarball with subtrees we don't need removed that would be awesoem.
After all MIR approvals are given on Source, and me (as well as likely the security Team later) probably would love to see a much much smaller source (since you only use so few of it).

It generally seems well maintained upstream and as a package. So yeah once this i trimmed down I'd give it a MIR ack and we can move it to the security-team.
If they ack as well then the Archive-Admins can make the final call of "yeah lets support it despite being blobs, like the other such cases".

For now re-assigning to Dave to come up with the reduced source (or to convince otherwise).