Bug impact:
Joining a domain when logged into Gnome, you suffer various breakage as dbus is restarted, from gnome-panel and nautilus reloading to network outage and desktop lock up.
Fix in the development branch:
This was addressed in Intrepid for version 4.1.2982-0ubuntu1, using the same patch that will be applied here.
Minimal patch:
--- likewise-open-4.1.2982-release.orig/domainjoin/scripts/ConfigureLogin.in
+++ likewise-open-4.1.2982-release/domainjoin/scripts/ConfigureLogin.in
@@ -302,8 +302,18 @@
fi
fi
else
+ if [ "$distroType" = "Ubuntu" ]; then
+ if [ -e /var/run/dbus/pid ] &&
+ ps --no-heading -p $(cat /var/run/dbus/pid) > /dev/null; then
+ invoke-rc.d dbus reload
+ result=$?
+ else
+ return 0
+ fi
+ else /etc/init.d/dbus restart result=$?
+ fi
fi
WaitForNetworkManager
return $result
TEST CASE:
NB: You'll need an AD setup to test that (a domain needs to be successfully joined).
$ sudo apt-get install likewise-open likewise-open-gui
System > Administration > Likewise, enter your domain name and click "Join domain"
Enter your AD admin password
Without the fix: dbus is restarted, gnome panels are reloaded, nautilus is restarted, and various additional breakage.
With the fix: dbus is gracefully reloaded, and nothing of that sort happens.
Regression potential:
The patch basically only affects new domain logins so it should not affect existing configurations in upgrades. It reloads dbus rather than restarting it, achieving the wanted refresh in DBUS without the unwanted breakage.
SRU report
Bug impact:
Joining a domain when logged into Gnome, you suffer various breakage as dbus is restarted, from gnome-panel and nautilus reloading to network outage and desktop lock up.
Fix in the development branch:
This was addressed in Intrepid for version 4.1.2982-0ubuntu1, using the same patch that will be applied here.
Minimal patch: open-4. 1.2982- release. orig/domainjoin /scripts/ ConfigureLogin. in open-4. 1.2982- release/ domainjoin/ scripts/ ConfigureLogin. in
/ etc/init. d/dbus restart
result= $? kManager
--- likewise-
+++ likewise-
@@ -302,8 +302,18 @@
fi
fi
else
+ if [ "$distroType" = "Ubuntu" ]; then
+ if [ -e /var/run/dbus/pid ] &&
+ ps --no-heading -p $(cat /var/run/dbus/pid) > /dev/null; then
+ invoke-rc.d dbus reload
+ result=$?
+ else
+ return 0
+ fi
+ else
+ fi
fi
WaitForNetwor
return $result
TEST CASE:
NB: You'll need an AD setup to test that (a domain needs to be successfully joined).
$ sudo apt-get install likewise-open likewise-open-gui
System > Administration > Likewise, enter your domain name and click "Join domain"
Enter your AD admin password
Without the fix: dbus is restarted, gnome panels are reloaded, nautilus is restarted, and various additional breakage.
With the fix: dbus is gracefully reloaded, and nothing of that sort happens.
Regression potential:
The patch basically only affects new domain logins so it should not affect existing configurations in upgrades. It reloads dbus rather than restarting it, achieving the wanted refresh in DBUS without the unwanted breakage.