session-setup-script doesn't know the username

Bug #1245957 reported by A User on 2013-10-29
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Light Display Manager
High
Robert Ancell
1.8
High
Robert Ancell
1.9
High
Robert Ancell
lightdm (Ubuntu)
High
Robert Ancell
Saucy
High
Robert Ancell
Trusty
High
Robert Ancell

Bug Description

When the session-setup-script is called, the environment doesn't have $USER set. It worked in 13.04 and for the cleanup script.

To reproduce:
1. Configure LightDM to have a session-setup-script in [SeatDefaults]
2. Check the $USER environment variable in the script
Expected result:
$USER is set to the name of the session being started
Observed result:
$USER is not set

Regression potential:
- Low, the change just sets the variable as it used to be set in LightDM < 1.7.5

Related branches

CVE References

Quinn Balazs (qbalazs) wrote :

Please run "apport-collect 1245957" in order to attach the required logs.

Changed in ubuntu:
status: New → Invalid
affects: lightdm → lightdm (Ubuntu)
Changed in lightdm (Ubuntu):
status: New → Incomplete
no longer affects: ubuntu
Robert Ancell (robert-ancell) wrote :

No need for apport - I can confirm this.

Changed in lightdm:
assignee: nobody → Robert Ancell (robert-ancell)
Changed in lightdm (Ubuntu Saucy):
assignee: nobody → Robert Ancell (robert-ancell)
Changed in lightdm (Ubuntu Trusty):
assignee: nobody → Robert Ancell (robert-ancell)
Changed in lightdm:
status: New → In Progress
importance: Undecided → High
Changed in lightdm (Ubuntu Trusty):
status: Incomplete → In Progress
Changed in lightdm (Ubuntu Saucy):
status: New → Triaged
Changed in lightdm (Ubuntu Trusty):
importance: Undecided → High
Changed in lightdm (Ubuntu Saucy):
importance: Undecided → High
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:lightdm at revision 1829, scheduled for release in lightdm, milestone Unknown

Changed in lightdm:
status: In Progress → Fix Committed
description: updated
Changed in lightdm:
status: Fix Committed → Fix Released
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package lightdm - 1.9.1-0ubuntu1

---------------
lightdm (1.9.1-0ubuntu1) trusty; urgency=low

  * New upstream release:
    - Correctly set $XDG_SESSION_CLASS for greeters. This was regressed in 1.7.5
      for ConsoleKit and was never passed to logind. logind/ConsoleKit treat
      greeter sessions without this set as user sessions. This causes greeters
      to show the lightdm user able to be logged in with.
      (LP: #1242939)
    - Set $USER when running the session-setup-script. This is a regression from
      1.7.5. (LP: #1245957)
    - Fix notification of sessions being logged out. This is a regression from
      1.7.5 and caused greeters to show sessions logged in after they had been
      logged out. (LP: #1245295)
    - Refactor liblightdm user scanning to be simpler and more reliable. This
      fixes bugs where some properties wouldn't be updated when they changed in
      accounts service.
    - Add support for a "display-stopped-script" field in lightdm.conf. The
      "display-stopped-script" field allows us to run a script right after
      stopping the display server.
    - Allow dm-tool to run outside of a session if it doesn't need to be.
    - Set $MIR_SERVER_NAME to assign a name to launched sessions. Also use a
      "greeter-" prefix for greeter sessions for the benefit of
      unity-system-compositor.
 -- Robert Ancell <email address hidden> Wed, 30 Oct 2013 14:11:16 -0700

Changed in lightdm (Ubuntu Trusty):
status: In Progress → Fix Released
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package lightdm - 1.8.4-0ubuntu1

---------------
lightdm (1.8.4-0ubuntu1) saucy-security; urgency=low

  [ Marc Deslauriers ]
  * SECURITY UPDATE: improper guest account confinement (LP: #1243339)
    - CVE-2013-4459

  [ Robert Ancell ]
  * New upstream release:
    - Implement missing guest-wrapper functionality and enable it for Ubuntu.
    - Update AppArmor scripts to work in Ubuntu 13.10. (LP: #1243339)
  * debian/50-guest-wrapper.conf:
    - Configure guest session wrapper to use

lightdm (1.8.3-0ubuntu1) saucy; urgency=low

  * New upstream release:
    - Correctly set $XDG_SESSION_CLASS for greeters. This was regressed in 1.7.5
      for ConsoleKit and was never passed to logind. logind/ConsoleKit treat
      greeter sessions without this set as user sessions. This causes greeters
      to show the lightdm user able to be logged in with.
      (LP: #1242939)
    - Set $USER when running the session-setup-script. This is a regression from
      1.7.5. (LP: #1245957)
    - Fix notification of sessions being logged out. This is a regression from
      1.7.5 and caused greeters to show sessions logged in after they had been
      logged out. (LP: #1245295)
 -- Marc Deslauriers <email address hidden> Mon, 04 Nov 2013 13:35:26 -0500

Changed in lightdm (Ubuntu Saucy):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers