Greeter shows "LightDM" user due to XDG_SESSION_CLASS not being provided to logind or ConsoleKit
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Light Display Manager |
Fix Released
|
High
|
Robert Ancell | ||
1.8 |
Fix Released
|
High
|
Robert Ancell | ||
1.9 |
Fix Released
|
High
|
Robert Ancell | ||
lightdm (Ubuntu) |
Fix Released
|
High
|
Robert Ancell | ||
Saucy |
Fix Released
|
High
|
Robert Ancell | ||
Trusty |
Fix Released
|
High
|
Robert Ancell |
Bug Description
XDG_SESSION_CLASS not provided to logind or ConsoleKit.
The ConsoleKit support was regressed in 1.7.5 and it's never been passed to logind.
Without the greeter being marked as a "greeter" class both logind and ConsoleKit consider it an open session that must be logged out of before you can shutdown.
This cases AccountsService to report this user and it is shown in greeters.
To reproduce:
1. Boot to Unity Greeter
2. Log into guest account
3. Log out of guest account
Expected result:
Greeter shows user list same as before login
Observed result:
A new user is added - "Light Display Manager"
Regression potential:
This variable has not been set when using logind in Ubuntu so a low risk of other subtle behaviour changes.
Related branches
- PS Jenkins bot: Approve (continuous-integration)
- Robert Ancell: Approve
-
Diff: 1808 lines (+145/-151)121 files modifiedsrc/seat.c (+1/-0)
src/session-child.c (+4/-5)
src/session.c (+1/-13)
src/session.h (+0/-6)
tests/scripts/autologin-guest-fail-setup-script.conf (+1/-1)
tests/scripts/autologin-guest-in-background.conf (+1/-1)
tests/scripts/autologin-guest-logout.conf (+1/-1)
tests/scripts/autologin-guest-timeout.conf (+1/-1)
tests/scripts/autologin-in-background.conf (+1/-1)
tests/scripts/autologin-invalid-session.conf (+1/-1)
tests/scripts/autologin-invalid-user.conf (+1/-1)
tests/scripts/autologin-logout.conf (+1/-1)
tests/scripts/autologin-new-authtok.conf (+1/-1)
tests/scripts/autologin-password.conf (+1/-1)
tests/scripts/autologin-session-crash.conf (+1/-1)
tests/scripts/autologin-session-error.conf (+1/-1)
tests/scripts/autologin-timeout-in-background.conf (+1/-1)
tests/scripts/autologin-timeout.conf (+1/-1)
tests/scripts/autologin-xserver-crash.conf (+1/-1)
tests/scripts/cancel-authentication.conf (+1/-1)
tests/scripts/change-authentication.conf (+1/-1)
tests/scripts/crash-authenticate.conf (+1/-1)
tests/scripts/cred-error.conf (+1/-1)
tests/scripts/cred-expired.conf (+1/-1)
tests/scripts/cred-unavail.conf (+1/-1)
tests/scripts/dbus.conf (+1/-1)
tests/scripts/denied.conf (+1/-1)
tests/scripts/expired.conf (+1/-1)
tests/scripts/greeter-allow-guest.conf (+1/-1)
tests/scripts/greeter-default-session.conf (+1/-1)
tests/scripts/greeter-fail-start.conf (+1/-1)
tests/scripts/greeter-hide-users.conf (+1/-1)
tests/scripts/greeter-show-manual-login.conf (+1/-1)
tests/scripts/greeter-show-remote-login.conf (+1/-1)
tests/scripts/greeter-wrapper.conf (+1/-1)
tests/scripts/greeter-xserver-crash.conf (+2/-2)
tests/scripts/keyboard-layout.conf (+1/-1)
tests/scripts/language-no-accounts-service.conf (+1/-1)
tests/scripts/language.conf (+1/-1)
tests/scripts/lock-seat-console-kit.conf (+1/-1)
tests/scripts/lock-seat-return-session-console-kit.conf (+1/-1)
tests/scripts/lock-seat-return-session.conf (+1/-1)
tests/scripts/lock-seat.conf (+1/-1)
tests/scripts/lock-session-no-password.conf (+1/-1)
tests/scripts/lock-session-return-session.conf (+1/-1)
tests/scripts/lock-session.conf (+1/-1)
tests/scripts/login-crash-authenticate.conf (+1/-1)
tests/scripts/login-guest-disabled.conf (+1/-1)
tests/scripts/login-guest-fail-setup-script.conf (+2/-2)
tests/scripts/login-guest-logout.conf (+2/-2)
tests/scripts/login-guest-no-setup-script.conf (+1/-1)
tests/scripts/login-guest.conf (+1/-1)
tests/scripts/login-info-prompt.conf (+1/-1)
tests/scripts/login-invalid-session.conf (+1/-1)
tests/scripts/login-invalid-user.conf (+1/-1)
tests/scripts/login-logout.conf (+2/-2)
tests/scripts/login-long-password.conf (+1/-1)
tests/scripts/login-long-username.conf (+1/-1)
tests/scripts/login-manual-previous-session.conf (+1/-1)
tests/scripts/login-manual-remember-session.conf (+2/-2)
tests/scripts/login-manual.conf (+1/-1)
tests/scripts/login-multi-info-prompt.conf (+1/-1)
tests/scripts/login-multi-prompt.conf (+1/-1)
tests/scripts/login-new-authtok.conf (+1/-1)
tests/scripts/login-no-password.conf (+1/-1)
tests/scripts/login-pam.conf (+1/-1)
tests/scripts/login-pick-session.conf (+1/-1)
tests/scripts/login-previous-session.conf (+1/-1)
tests/scripts/login-remember-session.conf (+2/-2)
tests/scripts/login-remote-session.conf (+1/-1)
tests/scripts/login-session-crash.conf (+2/-2)
tests/scripts/login-two-factor.conf (+1/-1)
tests/scripts/login-wrong-password.conf (+1/-1)
tests/scripts/login-xserver-crash.conf (+2/-2)
tests/scripts/login.conf (+1/-1)
tests/scripts/mir-autologin.conf (+1/-1)
tests/scripts/mir-session.conf (+1/-1)
tests/scripts/no-config.conf (+1/-1)
tests/scripts/no-keyboard-layout.conf (+1/-1)
tests/scripts/no-language.conf (+1/-1)
tests/scripts/open-file-descriptors.conf (+1/-1)
tests/scripts/plymouth-active-vt.conf (+1/-1)
tests/scripts/plymouth-inactive-vt.conf (+1/-1)
tests/scripts/power-no-console-kit.conf (+1/-1)
tests/scripts/power-no-login1.conf (+1/-1)
tests/scripts/power-no-services.conf (+1/-1)
tests/scripts/power.conf (+1/-1)
tests/scripts/restart-authentication.conf (+1/-1)
tests/scripts/script-hook-fail-session-setup.conf (+1/-1)
tests/scripts/script-hooks.conf (+1/-1)
tests/scripts/session-stderr-backup.conf (+2/-2)
tests/scripts/switch-to-greeter-new-session.conf (+1/-1)
tests/scripts/switch-to-greeter-return-session-logout.conf (+2/-2)
tests/scripts/switch-to-greeter-return-session.conf (+1/-1)
tests/scripts/switch-to-greeter.conf (+1/-1)
tests/scripts/switch-to-user-existing.conf (+1/-1)
tests/scripts/switch-to-user-logout-active.conf (+1/-1)
tests/scripts/switch-to-user.conf (+1/-1)
tests/scripts/unity-compositor-command.conf (+1/-1)
tests/scripts/unity-compositor-fail-ready.conf (+1/-1)
tests/scripts/unity-compositor-fail-start.conf (+1/-1)
tests/scripts/unity-compositor-next-session.conf (+1/-1)
tests/scripts/unity-login.conf (+1/-1)
tests/scripts/unity-mir-greeter-mir-session.conf (+1/-1)
tests/scripts/unity-mir-greeter-x-session.conf (+1/-1)
tests/scripts/unity-mir-session-x-greeter.conf (+1/-1)
tests/scripts/unity-switch.conf (+2/-2)
tests/scripts/upstart-login.conf (+1/-1)
tests/scripts/user-renamed-invalid.conf (+1/-1)
tests/scripts/users.conf (+1/-1)
tests/scripts/vnc-command.conf (+1/-1)
tests/scripts/vnc-dimensions.conf (+1/-1)
tests/scripts/vnc-login.conf (+1/-1)
tests/scripts/vnc-open-file-descriptors.conf (+1/-1)
tests/scripts/xdmcp-server-login.conf (+1/-1)
tests/scripts/xdmcp-server-open-file-descriptors.conf (+1/-1)
tests/scripts/xserver-no-share.conf (+1/-1)
tests/src/test-gobject-greeter.c (+4/-1)
tests/src/test-python-greeter (+3/-0)
tests/src/test-qt-greeter.cpp (+4/-1)
tests/src/test-session.c (+4/-1)
CVE References
Changed in lightdm: | |
status: | New → In Progress |
Changed in lightdm (Ubuntu Trusty): | |
status: | New → In Progress |
Changed in lightdm (Ubuntu Saucy): | |
status: | New → In Progress |
assignee: | nobody → Robert Ancell (robert-ancell) |
Changed in lightdm (Ubuntu Trusty): | |
assignee: | nobody → Robert Ancell (robert-ancell) |
Changed in lightdm: | |
assignee: | nobody → Robert Ancell (robert-ancell) |
importance: | Undecided → High |
Changed in lightdm (Ubuntu Saucy): | |
importance: | Undecided → High |
Changed in lightdm (Ubuntu Trusty): | |
importance: | Undecided → High |
Changed in lightdm (Ubuntu Trusty): | |
status: | In Progress → Fix Committed |
summary: |
- XDG_SESSION_CLASS not provided to logind or ConsoleKit + Greeter shows "LightDM" user due to XDG_SESSION_CLASS not being provided + to logind or ConsoleKit |
description: | updated |
description: | updated |
Changed in lightdm: | |
status: | Fix Committed → Fix Released |
Fix committed into lp:lightdm at revision 1820, scheduled for release in lightdm, milestone Unknown