Ubuntu
liferea package

  1. Bug #203413
  2. Comment #14

Comment 14 for bug 203413

Revision history for this message
In , Edilee-mozilla (edilee-mozilla) wrote :

Created an attachment (id=305418)
v1.2

(In reply to comment #13)
> r=sdwilsh for what it's worth
>
> >+ rv = fixURI->BindUTF8StringParameter(0, *urisToUnescape[i]);
> >+ NS_ENSURE_SUCCESS(rv, rv);
> >+
> >+ (void)textToSubURI->UnEscapeURIForUI(charset, *urisToUnescape[i], uriSpec);
> >+
> >+ rv = fixURI->BindStringParameter(1, uriSpec);
> >+ NS_ENSURE_SUCCESS(rv, rv);
> >+
> >+ rv = fixURI->Execute();
> >+ NS_ENSURE_SUCCESS(rv, rv);
> I think it'd probably be best here to do
> if (NS_FAILED(rv)) continue;
 Switched both loops to use NS_SUCCEEDED then append string or NS_SUCCEEDED for both binding and then execute.

Additionally, changed the BindStatementURI to if (NS_FAILED() || empty) use UTF8.