Comment 3 for bug 1528297

Revision history for this message
Colin Watson (cjwatson) wrote :

I *think* the relevant C code is non-compliant. C99 6.7.5.2(4) "If the size is not present, the array type is an incomplete type"; 6.7.5.3(12) "If the function declarator is not part of a definition of that function, parameters may have incomplete type". That would seem to imply that in the situation where the declarator is part of a definition of the function, as in this case, parameters may not have incomplete type, although oddly I can't find an explicit statement of that. Perhaps a more awake C standards pedant could find one? :-)

The attached patch can be added to the top of the patch stack of libvpx 1.4.0-4 and avoids this construction. It at least compiles on the armhf porter box; I haven't tried doing anything with it at run-time. I assume that a similar change can be applied to oxide-qt, though I also haven't tried that.