Ubuntu
libvirt package

  1. Bug #869553
  2. Comment #17

Comment 17 for bug 869553

Revision history for this message
Jamie Strandboge (jdstrand) wrote :

Serge,

Sorry for the delay.

This patch seems fine assuming that the behavior is expected (ie, the path is deleted intentionally). I think I'd prefer to use VIR_WARN() instead of virSecurityReportError(). Perhaps:
   VIR_WARN("could not find path for descriptor %s, skipping", proc);

IIRC, the use of virSecurityReportError() stops error reporting and may mask other problems, so we only want to warn here. If the removed path behavior is expected, getting it upstream (using VIR_WARN()) should not be a problem.