Comment 10 for bug 2002771
Revision history for this message
| Christian Ehrhardt (paelzer) wrote | #10 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
I'm partially ok with this, it explains:
1. Why it isn't restored in the first place
2. Why our experiments in comment 5 behaved so different as the hot add/remove was a qcow that was not readonly, due to that it behaved differently than cdrom insert (which automatically is readonly).
To be sure I combined all former experiments in one and re-run them checking if it all is consistent in regard to the explanation we got.
The last element of confusion out of our experiments was about the nbd (comment 7) being changed back to root:root is also clear now. This reminded me of bug 691590 where we fixed this for "normal" files.
/dev/nbd is stored on devfs which has no xattr support that is needed to "remember" the owner.
I'll bring that up upstream as well for awareness.
=> https:/
Notes on full repro of all cases:
# Prep different kind of potential attachments
```
# 1. Create a libvirt guest your preferred way
# 2. get an iso of your choice
$ wget https:/
$ sudo mv ubuntu-
$ sudo ls -laF /var/lib/
-rw-rw-r-- 1 ubuntu ubuntu 1975971840 Feb 17 21:57 /var/lib/
# 3. Create test image
$ sudo qemu-img create -f qcow2 /var/lib/
$ ll /var/lib/
-rw-r--r-- 1 root root 196616 Aug 7 08:58 /var/lib/
# 4. Create test to be available as disk
$sudo qemu-img create -f qcow2 /var/lib/
$ sudo qemu-nbd --connect=/dev/nbd0 /var/lib/
$ sudo sgdisk -n 0:0:0 /dev/nbd0
Creating new GPT entries in memory.
The operation has completed successfully.
$ ll /dev/nbd0
brw-rw---- 1 root disk 43, 0 Aug 7 09:00 /dev/nbd0
```
So after this we have:
- an .iso that is user owned
- a .qcow2 that is root:root
- a block device that is root:disk
In one shot that looks like:
```
$ sudo ls -laF /var/lib/
brw-rw---- 1 root disk 43, 0 Aug 7 09:00 /dev/nbd0
-rw-r--r-- 1 root root 196616 Aug 7 08:58 /var/lib/
-rw-rw-r-- 1 ubuntu ubuntu 1975971840 Feb 17 21:57 /var/lib/
```
# Variant A - start and stop statically with the guest
Guest XML section for those devices:
```
<disk type='file' device='disk'>
<driver name='qemu' type='qcow2' cache='none'/>
<source file='/
<target dev='vdd' bus='virtio'/>
</disk>
<disk type='block' device='disk'>
<driver name='qemu' type='raw' cache='none'/>
<source dev='/dev/nbd0'/>
<target dev='vde' bus='virtio'/>
</disk>
<disk type='file' device='cdrom'>
<driver name='qemu' type='raw'/>
<source file='/
<target dev='sda' bus='scsi'/>
<readonly/>
</disk>
```
Pre
```
$ sudo ls -laF /var/lib/
brw-rw---- 1 root disk 43, 0 Aug 7 09:00 /dev/nbd0
-rw-r--r-- 1 root root 196616 Aug 7 08:58 /var/lib/
-rw-rw-r-- 1 ubuntu ubuntu 1975971840 Feb 17 21:57 /var/lib/
```
Running
```
$ sudo ls -laF /var/lib/
brw-rw---- 1 root disk 43, 0 Aug 7 09:00 /dev/nbd0
-rw-r--r-- 1 libvirt-qemu kvm 196616 Aug 7 08:58 /var/lib/
-rw-rw-r-- 1 libvirt-qemu kvm 1975971840 Feb 17 21:57 /var/lib/
```
Post
```
sudo ls -laF /var/lib/
brw-rw---- 1 root root 43, 0 Aug 7 09:26 /dev/nbd0
-rw-r--r-- 1 root root 196616 Aug 7 08:58 /var/lib/
-rw-rw-r-- 1 libvirt-qemu kvm 1975971840 Feb 17 21:57 /var/lib/
```
As expected that changed the qcow file, left disk ndb0 untouched and does not restore the iso file.
So far all behaves as explained.
# Variant B - hot add/remove
Keep this in the guest config (cdrom without disk inserted).
Remove the qcow and nbd devices.
```
<disk type='file' device='cdrom'>
<driver name='qemu' type='raw'/>
<target dev='sda' bus='scsi'/>
<readonly/>
<address type='drive' controller='0' bus='0' target='0' unit='0'/>
</disk>
```
Use the XML shown above in the guest for test-qcow2.xml and test-nbd.xml files used in hot add/remove.
```
$ for f in test-*; do echo "File $f:"; cat $f; done
File test-nbd.xml:
<disk type='block' device='disk'>
<driver name='qemu' type='raw' cache='none'/>
<source dev='/dev/nbd0'/>
<target dev='vde' bus='virtio'/>
</disk>
File test-qcow2.xml:
<disk type='file' device='disk'>
<driver name='qemu' type='qcow2' cache='none'/>
<source file='/
<target dev='vdd' bus='virtio'/>
</disk>
```
Now hot-add all of those in their way
```
$ virsh change-media j sda /var/lib/
Successfully inserted media.
$ virsh attach-device j test-qcow2.xml
Device attached successfully
$ virsh attach-device j test-nbd.xml
Device attached successfully
```
Pre
```
ubuntu@
brw-rw---- 1 root disk 43, 0 Aug 7 09:26 /dev/nbd0
-rw-r--r-- 1 root root 196616 Aug 7 08:58 /var/lib/
-rw-rw-r-- 1 ubuntu ubuntu 1975971840 Feb 17 21:57 /var/lib/
```
Running
```
$ sudo ls -laF /var/lib/
brw-rw---- 1 root disk 43, 0 Aug 7 09:26 /dev/nbd0
-rw-r--r-- 1 libvirt-qemu kvm 196616 Aug 7 08:58 /var/lib/
-rw-rw-r-- 1 libvirt-qemu kvm 1975971840 Feb 17 21:57 /var/lib/
```
Post
```
$ sudo ls -laF /var/lib/
brw-rw---- 1 root disk 43, 0 Aug 7 09:26 /dev/nbd0
-rw-r--r-- 1 root root 196616 Aug 7 08:58 /var/lib/
-rw-rw-r-- 1 libvirt-qemu kvm 1975971840 Feb 17 21:57 /var/lib/
```