Comment 9 for bug 1861125

Revision history for this message
In , dhildenb (dhildenb-redhat-bugs) wrote :

(In reply to Jiri Denemark from comment #1)
> Libvirt should only add <cpu mode='host-model'/> default CPU to the domain
> definition if query-machines QMP command returns "host-s390x-cpu" as
> default-cpu-type for the machine type used by the domain.
>
> Can you please check what QEMU started as
>
> /usr/bin/qemu-system-s390x -machine none,accel=kvm -nodefaults -nographic
>
> tells about s390-ccw-virtio-2.5 machine type when you call the query-machines
> QMP command?
>
> I guess it says "default-cpu-type": "host-s390x-cpu". If this is the case, we
> either need to fix QEMU not to advertise default CPUs for machine type for
> which using CPU models would not work or we need to add some kind of hack to
> libvirt. I'd prefer if QEMU could stop reporting the default cpu as it has
> the
> best knowledge about machine types which support CPU modeling.

Well ... "-cpu host" works just fine under any machine (even without cpu model support). So I don't think "default-cpu-type=host-s390x-cpu" is wrong for older machine types.