Comment 3 for bug 1789659

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

It essentially removes a check for concurrency.
At the time it was added it was considered safe, but never the less in 4.0 (Bionic) there could be races left - just as much as there could be races not yet detected upstream.
I'd think this has a higher than usual regression risk.

OTOH it applies clean and I haven't found a revert or follow on fix so far (a few months later).

Well, in detail it is replacing a broken locking (by a boolean) with delegating the responsibility to callers which are already considered safe.

I think it can be done, but depends on the SRU Teams opinion eventually.
To Drive an SRU I'd need steps to reproduce, do you have something to share that is better than "deploy a huge thing with terraform with those 20.000 commands"?
I assume for your testing you might already have simplified it.

I'll add the empty SRU Template and ask you to fill as much as possible, but as mentioned the steps to reproduce would be most important IMHO.