Comment 6 for bug 1788226

Final PPA (final patches as accepted upstream onto Bionic): https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/3379

Upgrade log:
Reading package lists... Done
Building dependency tree
Reading state information... Done
Calculating upgrade... Done
The following packages were automatically installed and are no longer required:
  linux-headers-4.15.0-29 linux-headers-4.15.0-29-generic linux-image-4.15.0-29-generic linux-modules-4.15.0-29-generic linux-modules-extra-4.15.0-29-generic linux-tools-4.15.0-29
  linux-tools-4.15.0-29-generic
Use 'sudo apt autoremove' to remove them.
The following packages will be upgraded:
  libspice-server1 libvirt-clients libvirt-daemon libvirt-daemon-system libvirt0
5 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
Need to get 4.446 kB of archives.
After this operation, 0 B of additional disk space will be used.
Do you want to continue? [Y/n] Y
Get:1 http://security.ubuntu.com/ubuntu bionic-security/main amd64 libspice-server1 amd64 0.14.0-1ubuntu2.2 [345 kB]
Get:2 http://ppa.launchpad.net/ci-train-ppa-service/3379/ubuntu bionic/main amd64 libvirt-daemon-system amd64 4.0.0-1ubuntu8.4 [80,7 kB]
Get:3 http://ppa.launchpad.net/ci-train-ppa-service/3379/ubuntu bionic/main amd64 libvirt-clients amd64 4.0.0-1ubuntu8.4 [596 kB]
Get:4 http://ppa.launchpad.net/ci-train-ppa-service/3379/ubuntu bionic/main amd64 libvirt-daemon amd64 4.0.0-1ubuntu8.4 [2.173 kB]
Get:5 http://ppa.launchpad.net/ci-train-ppa-service/3379/ubuntu bionic/main amd64 libvirt0 amd64 4.0.0-1ubuntu8.4 [1.251 kB]
Fetched 4.446 kB in 23s (192 kB/s)
Preconfiguring packages ...
(Reading database ... 168374 files and directories currently installed.)
Preparing to unpack .../libvirt-daemon-system_4.0.0-1ubuntu8.4_amd64.deb ...
Unpacking libvirt-daemon-system (4.0.0-1ubuntu8.4) over (4.0.0-1ubuntu8.3) ...
Preparing to unpack .../libvirt-clients_4.0.0-1ubuntu8.4_amd64.deb ...
Unpacking libvirt-clients (4.0.0-1ubuntu8.4) over (4.0.0-1ubuntu8.3) ...
Preparing to unpack .../libvirt-daemon_4.0.0-1ubuntu8.4_amd64.deb ...
Unpacking libvirt-daemon (4.0.0-1ubuntu8.4) over (4.0.0-1ubuntu8.3) ...
Preparing to unpack .../libvirt0_4.0.0-1ubuntu8.4_amd64.deb ...
Unpacking libvirt0:amd64 (4.0.0-1ubuntu8.4) over (4.0.0-1ubuntu8.3) ...
Preparing to unpack .../libspice-server1_0.14.0-1ubuntu2.2_amd64.deb ...
Unpacking libspice-server1:amd64 (0.14.0-1ubuntu2.2) over (0.14.0-1ubuntu2.1) ...
Setting up libspice-server1:amd64 (0.14.0-1ubuntu2.2) ...
Setting up libvirt0:amd64 (4.0.0-1ubuntu8.4) ...
Setting up libvirt-daemon (4.0.0-1ubuntu8.4) ...
Processing triggers for libc-bin (2.27-3ubuntu1) ...
Processing triggers for systemd (237-3ubuntu10.3) ...
Processing triggers for man-db (2.8.3-2) ...
Setting up libvirt-clients (4.0.0-1ubuntu8.4) ...
Setting up libvirt-daemon-system (4.0.0-1ubuntu8.4) ...
virtlockd.service is a disabled or a static unit, not starting it.
Setting up libvirt-daemon dnsmasq configuration.

Testcase (as outlined before):
- We get the clean shutdown call with the extradelay as needed
2018-08-23 07:47:37.775+0000: 65044: debug : virProcessKillPainfullyDelay:361 : vpid=65523 force=1 extradelay=80
- Since this is a rather long case it increases to SIGKILL after 10 seconds
2018-08-23 07:47:47.779+0000: 65044: debug : virProcessKillPainfullyDelay:380 : Timed out waiting after SIGTERM to process 65523, sending SIGKILL
- The process only has for a short period a defunct state (mem cleaning and such)
6 64055 65523 1 20 0 0 0 - Zl ? 6:58 [qemu-system-x86] <defunct>
- Afterwards the PID is gone, but signal 0 still hits, istead of giving up the extradleay saves libvirt and eventually the process is correctly shut down
$ virsh list
(empty now)

We do NOT see anything like the old fails:
libvirtd: virProcessKillPainfully:401 : Failed to terminate process 5114 with SIGKILL: Device or resource busy

Finally this also passed the >1000 cases general regression check suite.
I think we are really good on this SRU prep now.
I uploaded to bionic-unapproved and it is up to the SRU Team now.