Hi Jorge,
thanks for your prep work on this.
Checking prereqs.
#1 fixed in Dev?
I read the "there is a patch" before as "there is a -new- patch", but checked now.
This is in since version 3.2 which makes it fix released in Artful already.
While I work on 3.6 we don't need it to go on with this as a fix in the dev version is a prereq.
#2 Patch?
I reviewed your changes and I'm ok with the patch, headers and backport.
Also in general while I'm not so sure on unlimited in general I see why they can't set a better value int his case - and since this is as-upstream this is good.
#3 SRU Queue?
Last SRU just complete, I think we are good adding a new one to the queue.
#4 Regressions
Thanks for pre-testing on your side already, gives some extra confidence.
I also checked via a (very basic) sniff test, full tests will have to be done on proposed but that we always do.
Therefore ok for now to go on.
#5 SRU Template
You already provided half of it, it misses a few things like regression considerations.
I can add those, but then nothing seems to block us from sponsoring this for SRU review IMO.
Hi Jorge,
thanks for your prep work on this.
Checking prereqs.
#1 fixed in Dev?
I read the "there is a patch" before as "there is a -new- patch", but checked now.
This is in since version 3.2 which makes it fix released in Artful already.
While I work on 3.6 we don't need it to go on with this as a fix in the dev version is a prereq.
#2 Patch?
I reviewed your changes and I'm ok with the patch, headers and backport.
Also in general while I'm not so sure on unlimited in general I see why they can't set a better value int his case - and since this is as-upstream this is good.
#3 SRU Queue?
Last SRU just complete, I think we are good adding a new one to the queue.
#4 Regressions
Thanks for pre-testing on your side already, gives some extra confidence.
I also checked via a (very basic) sniff test, full tests will have to be done on proposed but that we always do.
Therefore ok for now to go on.
#5 SRU Template
You already provided half of it, it misses a few things like regression considerations.
I can add those, but then nothing seems to block us from sponsoring this for SRU review IMO.