Comment 11 for bug 1396070

Revision history for this message
bugproxy (bugproxy) wrote : Comment bridged from LTC Bugzilla

------- Comment From <email address hidden> 2014-11-28 05:29 EDT-------
(In reply to comment #14)
> Now too late but I had noticed that the provided patch #3 missed two changes
> from the upstream patch. Not sure how important those would be:
>
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index 1b8efb1..21309b0 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -10043,7 +10043,7 @@ virDomainVideoDefaultType(const virDomainDef *def)
> (STREQ(def->os.type, "xen") ||
> STREQ(def->os.type, "linux")))
> return VIR_DOMAIN_VIDEO_TYPE_XEN;
> - else if (def->os.arch == VIR_ARCH_PPC64)
> + else if ARCH_IS_PPC64(def->os.arch)
> return VIR_DOMAIN_VIDEO_TYPE_VGA;
> else
> return VIR_DOMAIN_VIDEO_TYPE_CIRRUS;
> diff --git a/src/cpu/cpu_powerpc.c b/src/cpu/cpu_powerpc.c
> index 67cb9ff..d591c18 100644
> --- a/src/cpu/cpu_powerpc.c
> +++ b/src/cpu/cpu_powerpc.c
> @@ -38,7 +38,7 @@
>
> VIR_LOG_INIT("cpu.cpu_powerpc");
>
> -static const virArch archs[] = { VIR_ARCH_PPC64 };
> +static const virArch archs[] = { VIR_ARCH_PPC64, VIR_ARCH_PPC64LE };
>
> struct ppc_vendor {
> char *name;
>
> This bug was fixed in the package libvirt - 1.2.8-0ubuntu16
>
> ---------------
> libvirt (1.2.8-0ubuntu16) vivid; urgency=medium
>
> * debian/patches/add-ppc64le-support.patch: Added patches needed
> for ppc64le support. (LP: #1396070)
> -- Chuck Short <email address hidden> Thu, 27 Nov 2014 08:57:35 -0500

Yes, these are needed. Wonder how this didnt get flagged in the build test.
In fact the upstream tree 1.2.10+ has these patches in. Is there a chance the upcoming 1.2.11 release could be packaged for Ubuntu ?