Comment 2 for bug 2004039

Revision history for this message
Simon Quigley (tsimonq2) wrote :

Hi Tobias, thanks for your interest in this bug!

While I did not do a code review of the patch itself, I have some general feedback on the diff and the bug report itself that I hope you find helpful:
 - The version should be 1.6.2-0ubuntu1.1 instead of 1.6.2-0ubuntu2, following Stable Release Update guidelines. Generally speaking, 1.6.2-0ubuntu2 would only be appropriate for the development release.
 - As a sponsor, I prefer DEP-3 headers[1] over Git patch headers, so the patch stays machine-readable (and so bug references such as this one and the Debian bug can be inserted).
 - The bug report description should be more thorough; does Xorg hard-crash, or is there a workaround? Could you provide specific instructions to reproduce the failure, please? Same with verification steps.

For now, I'm unsubscribing the sponsors team. Please resubscribe the team once most (or all) of these points have been addressed.

Thank you!

[1] https://dep-team.pages.debian.net/deps/dep3/