Comment 22 for bug 1348384

Revision history for this message
Robie Basak (racb) wrote :

I've just spoken with Till about this on IRC.

It seems to me that there are two patches involved here. Patch 1 (fix-document-rotation) fixed bug 1242678, but caused a regression (tracked by this bug: bug 1348384). Marek has kindly provided patch 2 (erase-page) that fixes this.

But patch 1 was reverted upstream, and we don't know what the current status of this is. So patch 1 has inadvertently caused Ubuntu to diverge from upstream, and this is what is causing the current pain.

I think that taking patch 2 is going to exacerbate the problem. Then we'll be even further diverged from upstream, and this will make future merges harder, which sets Ubuntu up to end up with an old version for fear of regression.

So to avoid making the situation worse, can someone please resolve the situation of these two bugs upstream before pushing this patch into Ubuntu? What has upstream done about bug 1242678? Would it be better to revert patch 1 from Ubuntu, and take what upstream has done to fix it instead, thus avoiding this regression altogether and bring us closer to upstream?

Finally, when preparing debdiffs, please use dep3 headers (http://dep.debian.net/deps/dep3/) to make it easier to follow upstream status on these patches.

Thanks.