Comment 1 for bug 1705538

Revision history for this message
Steve Langasek (vorlon) wrote :

For 17.10, I've attempted to upload the 1.1.18 upstream version rather than cherry-picking individual fixes. However, the package fails to build on the Ubuntu builders due to a series of bugs.

 - when the test binary is built, it is linked against libservicelog.so, not libservicelog.la. This means that there is no libtool wrapper script to set the path; and the test binary only ever works if there is an already-installed version of libservicelog on the system path which is being tested instead of the just-built version.
 - if servicelog_open() returns a failure, test_libservicelog segfaults because it tries to dereference a null pointer.
 - if /var/lib/libservicelog/ does not already exist on the system, servicelog_open() will *always* fail.

I've written patches for the first two issues; but the hard-coding of a system path in the library makes it difficult to fix the third issue in a way that is compatible with an unprivileged build environment.

I'm attaching the two patches, and will disable the test suite in the Ubuntu package pending resolution of the third issue. This is not a regression since the test suite is new since 1.1.16.