Comment 4 for bug 1030335

Revision history for this message
Jamie Strandboge (jdstrand) wrote :

 * Builds with only main enabled
 * Has a small test suite but it is disabled due to dbus requirement
 * This package does not exist in Debian yet
 * It has a symbols file
 * Should have a bug subscriber
 * It has a watch file
 * Lintian warnings (lintian ../source/*dsc ../binary/*.deb). Two lintian warnings:
libsecret-tools_0.8-0ubuntu1_amd64.deb:
W: libsecret-tools: copyright-refers-to-deprecated-bsd-license-file
W: libsecret-tools: binary-without-manpage usr/bin/secret-tool
 * debian/rules is clean
 * It has some compiler warnings:
secret-methods.c:369:9: warning: 'items' may be used uninitialized in this function [-Wmaybe-uninitialized]
secret-tool.c:182:9: warning: ignoring return value of 'write', declared with attribute warn_unused_result [-Wunused-result]
 * No CVE history (the package is new). No initscripts or upstart jobs, no setuid, no use of fscaps, no use of sudo/su/pkexec, no installed dbus services (though it is designed to connect over dbus to a SecretService like gnome keyring daemon) and no cron jobs. It is built with hardening options (found 'Stack protected: no, not found!' but looks like no strings on the stack, so ok).
 * memory operations seem ok. there was some pretty hairy memory operations in egg/egg-secure-memory.c, but these are almost identical to what we have in gnome-keyring (which is also good for maintenance)

ACK, but please add a bug subscriber.