Comment 0 for bug 1391322

Revision history for this message
bugproxy (bugproxy) wrote :

---Problem Description---
Please include these additional patches to fix support for LE.

Machine Type = POWER8

Userspace tool common name: rtas_errd

Userspace package: librtas

Please pull below patchset from upstream.

upstream repo : git://git.code.sf.net/p/librtas/code

commit 1d54a4a346f9111e1326dfdec756fd78360add42
Author: Nathan Fontenot <email address hidden>
Date: Fri Oct 17 10:18:40 2014 -0400

    When we pass _hi and _lo 32bits of a 64bit value, we
    should convert the host endian value carefully.

    i.e,
            X_hi = htobe32(BITS32_HI(X))
            X_lo = htobe32(BITS32_LO(X))

    and not :
            X_hi = BITS32_HI(htobe64(X))

    NOTE: This patch is untested, but I believe this patch
    is good to have than the current faulty conversion.

    This patch fixes all such occurrences in librtas.

    Signed-off-by: Suzuki K. Poulose <email address hidden>

commit e5541e1a5c83ce47cc492abcd7343d65763dcefe
Author: Nathan Fontenot <email address hidden>
Date: Fri Oct 17 10:17:28 2014 -0400

    Use rpm macros for standard paths

    Signed-off-by: Suzuki K. Poulose <email address hidden>

commit 8ef7f827e28e3cd284f6be5686a987786be7502d
Author: Nathan Fontenot <email address hidden>
Date: Fri Oct 17 10:16:16 2014 -0400

    This patch fixes the conversion of args for paltform-dump call.
    platform dump passes 64bit values as, a pair of 32bit values.
    val_hi and val_lo. So when we convert a value 'X' to 32bit hi and lo
    values in BE, we should follow the below approach :

    X_hi = htobe32(BITS32_HI(X))
    X_lo = htobe32(BITS32_LO(X))

    and NOT
    X_tmp = htobe64(X);
    X_hi = BITS32_HI(X_tmp), X_lo = BITS32_LO(X_tmp)

    This patch has been tested with rtas_errd/extract_platdump to retrieve a
    dump from FSP.

    Signed-off-by: Suzuki K. Poulose <email address hidden>

commit 52263814c46210b51e564748050299620726dfd1
Author: Nathan Fontenot <email address hidden>
Date: Fri Oct 17 10:12:54 2014 -0400

    Fix LE parsing of SRC/FRU events

    Signed-off-by: Thomas L Falcon <email address hidden>
    Signed-off-by: Suzuki K. Poulose <email address hidden>

commit ac0a91d2730740cd279d80ccd4c83b0a04827d1d
Author: Nathan Fontenot <email address hidden>
Date: Fri Oct 17 10:10:29 2014 -0400

    LE Support for SRC/FRU events

    Signed-off-by: Nathan Fontenot <email address hidden>

@ Canonical,

We have recently made new upstream release (v1.3.13). If you are fine please pull new version.. -OR- just the patches mentioned here..

-Vasant