Comment 4 for bug 1884326

Revision history for this message
Ɓukasz Zemczak (sil2100) wrote :

Hey Olivier! I looked at the librsvg upload in the queue just now. I'm a bit worried about the symbols removal in librsvg2-2. Looking at the diff:

diff -Nru librsvg-2.48.2/debian/librsvg2-2.symbols librsvg-2.48.7/debian/librsvg2-2.symbols
--- librsvg-2.48.2/debian/librsvg2-2.symbols 2020-04-07 20:23:36.000000000 +0000
+++ librsvg-2.48.7/debian/librsvg2-2.symbols 2020-06-19 21:19:37.000000000 +0000
@@ -55,8 +55,6 @@
  rsvg_rust_handle_get_base_url@Base 2.46.0
  rsvg_rust_handle_get_dimensions@Base 2.46.0
  rsvg_rust_handle_get_dimensions_sub@Base 2.46.0
- rsvg_rust_handle_get_dpi_x@Base 2.46.0
- rsvg_rust_handle_get_dpi_y@Base 2.46.0
  rsvg_rust_handle_get_geometry_for_element@Base 2.46.0
  rsvg_rust_handle_get_geometry_for_layer@Base 2.46.0
  rsvg_rust_handle_get_intrinsic_dimensions@Base 2.46.0
@@ -76,8 +74,7 @@
  rsvg_rust_handle_render_layer@Base 2.46.0
  rsvg_rust_handle_set_base_gfile@Base 2.46.0
  rsvg_rust_handle_set_base_url@Base 2.46.0
- rsvg_rust_handle_set_dpi_x@Base 2.46.0
- rsvg_rust_handle_set_dpi_y@Base 2.46.0
+ rsvg_rust_handle_set_dpi_x_y@Base 2.48.5
  rsvg_rust_handle_set_size_callback@Base 2.46.0
  rsvg_rust_handle_set_stylesheet@Base 2.47.3
  rsvg_rust_handle_set_testing@Base 2.46.0

Doesn't his break the current ABI? Those seem to be public symbols that are being removed. Doesn't this warrant a librsvg soname bump, to something like librsvg2-3 or something? I'm worried about this breaking existing applications.

Was this investigated? Am I just being overly paranoid?