Doesn't his break the current ABI? Those seem to be public symbols that are being removed. Doesn't this warrant a librsvg soname bump, to something like librsvg2-3 or something? I'm worried about this breaking existing applications.
Was this investigated? Am I just being overly paranoid?
Hey Olivier! I looked at the librsvg upload in the queue just now. I'm a bit worried about the symbols removal in librsvg2-2. Looking at the diff:
diff -Nru librsvg- 2.48.2/ debian/ librsvg2- 2.symbols librsvg- 2.48.7/ debian/ librsvg2- 2.symbols 2.48.2/ debian/ librsvg2- 2.symbols 2020-04-07 20:23:36.000000000 +0000 2.48.7/ debian/ librsvg2- 2.symbols 2020-06-19 21:19:37.000000000 +0000 rust_handle_ get_base_ url@Base 2.46.0 rust_handle_ get_dimensions@ Base 2.46.0 rust_handle_ get_dimensions_ sub@Base 2.46.0 handle_ get_dpi_ x@Base 2.46.0 handle_ get_dpi_ y@Base 2.46.0 rust_handle_ get_geometry_ for_element@ Base 2.46.0 rust_handle_ get_geometry_ for_layer@ Base 2.46.0 rust_handle_ get_intrinsic_ dimensions@ Base 2.46.0 rust_handle_ render_ layer@Base 2.46.0 rust_handle_ set_base_ gfile@Base 2.46.0 rust_handle_ set_base_ url@Base 2.46.0 handle_ set_dpi_ x@Base 2.46.0 handle_ set_dpi_ y@Base 2.46.0 handle_ set_dpi_ x_y@Base 2.48.5 rust_handle_ set_size_ callback@ Base 2.46.0 rust_handle_ set_stylesheet@ Base 2.47.3 rust_handle_ set_testing@ Base 2.46.0
--- librsvg-
+++ librsvg-
@@ -55,8 +55,6 @@
rsvg_
rsvg_
rsvg_
- rsvg_rust_
- rsvg_rust_
rsvg_
rsvg_
rsvg_
@@ -76,8 +74,7 @@
rsvg_
rsvg_
rsvg_
- rsvg_rust_
- rsvg_rust_
+ rsvg_rust_
rsvg_
rsvg_
rsvg_
Doesn't his break the current ABI? Those seem to be public symbols that are being removed. Doesn't this warrant a librsvg soname bump, to something like librsvg2-3 or something? I'm worried about this breaking existing applications.
Was this investigated? Am I just being overly paranoid?