Comment 5 for bug 1950467

Revision history for this message
Dan Streetman (ddstreet) wrote :

> I have updated the patch

thanks! and thanks for adding details to the changelog entry as well to clarify the backport changes, and to update the vcs links.

> The new requirement to include a "~bpo" string seems a bit unfortunate

The current rules would require the version to change as:

1:7.1.7-0ubuntu0.21.04.1
to
1:7.1.7-0ubuntu0.21.04.1~bpo20.04.1

I do think that generally makes sense, even though including both the '21.04.1' and '20.04.1' releases might be at first confusing. Note this does follow the backport version convention used by Debian:
https://backports.debian.org/Contribute/#index4h3

The only possible future problem with that versioning I think is if the full 7.1.7 version was, at some point, *fully* SRU'ed back into focal. At that point, the SRU version would usually be a version like 1:7.1.7-0ubuntu0.20.04.1, which would actually be a lower version number than the version in backports. However, I don't think you are planning to do that (right?), and it's also generally not allowed to do using the SRU process.

Other than the version number, the backport looks good to me; if you can upload it with the proper version number, I'm happy to approve it.