Comment 26 for bug 1373928

Revision history for this message
In , Matus-kukan (matus-kukan) wrote :

Sorry, I was probably not clear enough in my first comment. :-/

(In reply to comment #22)
> So we should change the dlopen() mechanism in the mergedlibs case

Ideally we would just kill this dlopen.

> Is there an "#ifdef" we can do to detect mergedlibs case?

I guess it was removed because it's not necessary..
git grep CUI_DLL_NAME vcl/ shows

-DCUI_DLL_NAME=\"$(call gb_Library_get_runtime_filename,$(call gb_Library__get_name,cui))\" \

in makefile, and you can then use in source CUI_DLL_NAME instead of just "cui" without any #ifdefs
It expands to the exact platform specific name, so no need for SVLIBRARY then.

But really, we should kill that ugly createDataAccessToolsFactory mess and benefit. :-)