Comment 0 for bug 2023532

[Impact]

librem-ec-acpi-dkms (EC ACPI in Purism Librem devices) fails to build on linux 6.2 in jammy with the following errors:

/var/lib/dkms/librem_ec_acpi/0.9.1/build/librem_ec_acpi.c:276:24: error: initialization of ‘int (*)(struct power_supply *, struct acpi_battery_hook *)’ from incompatible pointer type ‘int (*)(struct power_supply *)’ [-Werror=incompatible-pointer-types]
  276 | .add_battery = librem_ec_battery_add,
      | ^~~~~~~~~~~~~~~~~~~~~
/var/lib/dkms/librem_ec_acpi/0.9.1/build/librem_ec_acpi.c:276:24: note: (near initialization for ‘librem_ec_battery_hook.add_battery’)
/var/lib/dkms/librem_ec_acpi/0.9.1/build/librem_ec_acpi.c:277:27: error: initialization of ‘int (*)(struct power_supply *, struct acpi_battery_hook *)’ from incompatible pointer type ‘int (*)(struct power_supply *)’ [-Werror=incompatible-pointer-types]
  277 | .remove_battery = librem_ec_battery_remove,
      | ^~~~~~~~~~~~~~~~~~~~~~~~
/var/lib/dkms/librem_ec_acpi/0.9.1/build/librem_ec_acpi.c:277:27: note: (near initialization for ‘librem_ec_battery_hook.remove_battery’)
/var/lib/dkms/librem_ec_acpi/0.9.1/build/librem_ec_acpi.c:773:27: error: initialization of ‘void (*)(struct acpi_device *)’ from incompatible pointer type ‘int (*)(struct acpi_device *)’ [-Werror=incompatible-pointer-types]
  773 | .remove = librem_ec_remove,
      | ^~~~~~~~~~~~~~~~
/var/lib/dkms/librem_ec_acpi/0.9.1/build/librem_ec_acpi.c:773:27: note: (near initialization for ‘librem_ec_driver.ops.remove’)
cc1: some warnings being treated as errors

[Test case]

 $ sudo apt install librem-ec-acpi-dkms

[Fix]

Backport the right patch(es) from lunar to properly support the new linux 6.2 ABI.

[Regression potential]

librem-ec-acpi-dkms is the EC ACPI driver for Purism Librem devices, so we may experience potential kernel regressions only on these devices that are using ACPI.

ProblemType: Bug
DistroRelease: Ubuntu 22.04
Package: librem-ec-acpi-dkms 0.9.1-2ubuntu2
ProcVersionSignature: User Name 6.2.0-23.23~22.04.1-generic 6.2.12
Uname: Linux 6.2.0-23-generic x86_64
ApportVersion: 2.20.11-0ubuntu82.5
Architecture: amd64
CasperMD5CheckResult: unknown
Date: Mon Jun 12 07:43:56 2023
PackageArchitecture: all
SourcePackage: librem-ec-acpi
UpgradeStatus: No upgrade log present (probably fresh install)