Ubuntu patch breaks libproxy
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
libproxy (Ubuntu) |
Fix Released
|
High
|
Unassigned | ||
Jaunty |
Fix Released
|
High
|
Unassigned |
Bug Description
We got reports upstream of libproxy: libproxy is not working on Ubuntu.
A user, even when having a Gnome configuration set, get's a warning wpad disabled and the lib falls back to direct, bypassing his proxy.
I would say this part of your 50_px-wpad-
@@ -591,7 +608,12 @@ px_proxy_
}
// If the config plugin returned an invalid config type or malformed URL, fall back to 'wpad://'
- if (!(!strncmp(
+ if (!do_wpad_fallback)
+ {
+ fprintf(stderr, "*** Config plugin returned invalid URL type and WPAD fallback disabled! Falling back to direct...\n");
+ goto do_return;
+ }
+ else if (!(!strncmp(
!strncmp(
!strncmp(
!strcmp (config->url, "wpad://") ||
The only check here seems to be if do_wpad_fallback is enabled, if not give an error and fall back to direct://, without checkling if the config otherwise would have been valid.
I suggest this to && linked with the rest of the original IF.
DimStar wrote:
> We got reports upstream of libproxy: libproxy is not working on Ubuntu.
> A user, even when having a Gnome configuration set, get's a warning
> wpad disabled and the lib falls back to direct, bypassing his proxy.
Thanks for the notice Dominique! I'll look at it this weekend.