diff -u libproxy-0.2.3/debian/changelog libproxy-0.2.3/debian/changelog --- libproxy-0.2.3/debian/changelog +++ libproxy-0.2.3/debian/changelog @@ -1,3 +1,13 @@ +libproxy (0.2.3-0ubuntu5) jaunty; urgency=low + + * debian/patches/50_px-wpad-fallback-env-var.patch: + - Fix logic to not bypass the config plugin when the env variable + isn't set. We don't do wpad fallback if the env variable isn't set, + but there's not reason to ignore the config file if one is provided. + LP: #354475. + + -- Emilio Pozuelo Monfort Sat, 11 Apr 2009 14:39:28 +0200 + libproxy (0.2.3-0ubuntu4) jaunty; urgency=low * Upload package from Debian NEW to Jaunty. diff -u libproxy-0.2.3/debian/patches/50_px-wpad-fallback-env-var.patch libproxy-0.2.3/debian/patches/50_px-wpad-fallback-env-var.patch --- libproxy-0.2.3/debian/patches/50_px-wpad-fallback-env-var.patch +++ libproxy-0.2.3/debian/patches/50_px-wpad-fallback-env-var.patch @@ -1,6 +1,5 @@ -diff -ruNp libproxy-0.2.3/src/lib/proxy_factory.c libproxy-0.2.3.new/src/lib/proxy_factory.c ---- libproxy-0.2.3/src/lib/proxy_factory.c 2008-06-05 22:56:15.000000000 +0200 -+++ libproxy-0.2.3.new/src/lib/proxy_factory.c 2009-03-03 00:37:14.000000000 +0100 +--- src/lib/proxy_factory.c.orig 2009-04-11 14:23:45.000000000 +0200 ++++ src/lib/proxy_factory.c 2009-04-11 14:28:23.000000000 +0200 @@ -514,6 +514,8 @@ px_proxy_factory_get_proxies (pxProxyFac pxConfig *config = NULL; char **response = px_strsplit("direct://", ";"); @@ -38,14 +37,27 @@ -@@ -591,7 +608,12 @@ px_proxy_factory_get_proxies (pxProxyFac - } - - // If the config plugin returned an invalid config type or malformed URL, fall back to 'wpad://' -- if (!(!strncmp(config->url, "http://", 7) || -+ if (!do_wpad_fallback) -+ { -+ fprintf(stderr, "*** Config plugin returned invalid URL type and WPAD fallback disabled! Falling back to direct...\n"); -+ goto do_return; -+ } -+ else if (!(!strncmp(config->url, "http://", 7) || +@@ -595,20 +612,23 @@ px_proxy_factory_get_proxies (pxProxyFac !strncmp(config->url, "socks://", 8) || !strncmp(config->url, "pac+", 4) || !strcmp (config->url, "wpad://") || +- !strcmp (config->url, "direct://"))) ++ !strcmp (config->url, "direct://")) ++ && do_wpad_fallback) + { + fprintf(stderr, "*** Config plugin returned invalid URL type! Falling back to auto-detection...\n"); + px_free(config->url); + config->url = px_strdup("wpad://"); + } +- else if (!strncmp(config->url, "pac+", 4) && !px_url_is_valid(config->url + 4)) ++ else if (!strncmp(config->url, "pac+", 4) && !px_url_is_valid(config->url + 4) ++ && do_wpad_fallback) + { + fprintf(stderr, "*** Config plugin returned malformed URL! Falling back to auto-detection...\n"); + px_free(config->url); + config->url = px_strdup("wpad://"); + } + else if ((!strncmp(config->url, "http://", 7) || !strncmp(config->url, "socks://", 8)) && +- !px_url_is_valid(config->url)) ++ !px_url_is_valid(config->url) && ++ do_wpad_fallback) + { + fprintf(stderr, "*** Config plugin returned malformed URL! Falling back to auto-detection...\n"); + px_free(config->url);