Comment 13 for bug 367577

Revision history for this message
Kenny Millington (kmdm) wrote :

@Steve:

Thanks for taking a look at this bug.

In my opinion the other upstream cherry picks are not needed to pass -s to cryptsetup (I've been running with the first/original fix for several months now without issue).

I believe the other cherry picks are a separate but very closely related bug in mount.crypt - for that reason it could very well make sense to apply all the fixes in one SRU rather than two.

All that being said I would welcome comments and/or better suggestions from j.engelh as the (apparent) upstream maintainer as well as clarification of his comment on 2009-06-08 about the key_size array being too small because if indeed it is and my use of the constant value is flawed then my debdiff needs correcting.

(Please note I'm not a C coder by any stretch of the imagination but I can read/understand it and apply patches from newer code revisions etc...)