Comment 2 for bug 1566238

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Similar to previous upstream release 2.6.0 this point release breaks abi:

--- debian/libica2.symbols (libica2_2.6.2-1_s390x)
+++ dpkg-gensymbolsTLDHhr 2016-04-06 01:37:33.551495418 +0000
@@ -15,15 +15,15 @@
  ctr_inc_single@Base 2.5.0
  delete_all@Base 2.5.0
  des_switch@Base 2.5.0
- drbg_check_zmem@Base 2.6.1
+#MISSING: 2.6.2-1# drbg_check_zmem@Base 2.6.1
  drbg_generate@Base 2.6.1
  drbg_get_entropy_input@Base 2.6.1
  drbg_get_nonce@Base 2.6.1
  drbg_hash_df@Base 2.6.1
  drbg_health_test@Base 2.6.1
  drbg_instantiate@Base 2.6.1
- drbg_mech_valid@Base 2.6.1
- drbg_recursive_mutex_init@Base 2.6.1
+#MISSING: 2.6.2-1# drbg_mech_valid@Base 2.6.1
+#MISSING: 2.6.2-1# drbg_recursive_mutex_init@Base 2.6.1
  drbg_reseed@Base 2.6.1
  drbg_sha512_generate@Base 2.6.1
  drbg_sha512_generate_ppno@Base 2.6.1
@@ -34,7 +34,7 @@
  drbg_sha512_reseed_ppno@Base 2.6.1
  drbg_sha512_uninstantiate@Base 2.6.1
  drbg_uninstantiate@Base 2.6.1
- drbg_zmem@Base 2.6.1
+#MISSING: 2.6.2-1# drbg_zmem@Base 2.6.1
  end_sigill_section@Base 2.5.0
  generate_pkcs11_mech_list@Base 2.5.0
  get_next_usr@Base 2.5.0

The missing functions have been converted to be static inlines, thus breaking the library ABI.

Looking at the code changes, there is a lot of code refactor.
Is there a minimal patch of actual performance improvements?

I see a lot of variables moving about and getting assigned at declaration, and things simply renamed (s/LENGTH_FOO_HASH/FOO_HASH_LENGTH/). 16.04 is way past feature freeze to land code refactors which break library ABI.