Comment 2 for bug 618757

Revision history for this message
Ken VanDine (ken-vandine) wrote :

I reviewed these, not sure what the right solution is for #1. I don't have any non-void functions that aren't returning something. The C code generated does create two functions for one lambda, one of which should return a gboolean but doesn't. The vala method is a void. I tried changing the vala code to return a bool and it produced the same C code. Also, I am not seeing these warnings on amd64, so perhaps the compiler flags are more forgiving. Think I should file a bug against valac?

For #2, also not seeing these warnings on amd64. Looking at the generated C code, the variables are initialized inside of an if block where they are also used. So this is safe, they aren't actually used outside.