French language locale missing : Gnome-Weather
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
| GNOME Weather |
Unknown
|
Medium
|
||
| Ubuntu Translations |
High
|
Gunnar Hjalmarsson | ||
| gnome-weather (Ubuntu) |
High
|
Unassigned | ||
| libgweather (Ubuntu) |
High
|
Unassigned | ||
| Xenial |
High
|
Unassigned | ||
| Zesty |
High
|
Unassigned | ||
| Artful |
High
|
Unassigned |
Bug Description
[Impact]
The variable GETTEXT_PACKAGE is set to "libgweather-3.0" when building libgweather, which makes the libgweather-common binary look for translations in files named "libgweather-
The uploaded package works around the issue by setting GETTEXT_PACKAGE to "libgweather".
In bionic the template name in Rosetta has been changed to "libgweather-3.0", and thus the workaround will be reversed.
[Test Case]
* Install French language support
* Start gnome-weather with:
LANGUAGE=fr gnome-weather
and find that the description of the weather type is displayed in
English.
* Install these packages from -proposed:
- gir1.2-gweather-3.0
- libgweather-3-6
- libgweather-common
* Start gnome-weather with:
LANGUAGE=fr gnome-weather
and find that the description of the weather type is now displayed
in French.
[Regression Potential]
None.
[Original description]
In Gnome Weather, part of it is not translated in french : cloudy, rain showers, etc. Should be : nuageux, pluie fine, etc.
I guess it's a missing french localization. Fedora does not have that problem. In Gnome-Software, they have a section for languages, under the extensions section.
NoOne (1noname) wrote : | #1 |
affects: | ubuntu-gnome → gnome-weather |
affects: | gnome-weather → gnome-weather (Ubuntu) |
Gunnar Hjalmarsson (gunnarhj) wrote : | #2 |
Jeremy Bicha (jbicha) wrote : | #3 |
Gunnar, could you check if libgweather provides those strings?
Gunnar Hjalmarsson (gunnarhj) wrote : | #4 |
In libgweather I find "Rain showers" but not "Cloudy". "Rain showers" is translated:
$ lsb_release -ds
Ubuntu 16.04.2 LTS
$ echo $(LANGUAGE=fr gettext --domain=
Averses
So this seems not to be it.
mrprobot (mrprobot) wrote : | #5 |
I can confirm this on a german install.
Sebastien Bacher (seb128) wrote : | #6 |
Thnaks for the bug report
Changed in gnome-weather (Ubuntu): | |
status: | New → In Progress |
importance: | Undecided → High |
Jeremy Bicha (jbicha) wrote : | #7 |
I believe these strings are in libgweather and not gnome-weather.
libgweather actually provides two potfiles, these strings should be in the libgweather potfile instead of the locations one.
https:/
https:/
https:/
From the publishing history, libgweather has been in main continuously for years.
Changed in libgweather (Ubuntu): | |
importance: | Undecided → High |
status: | New → Confirmed |
NoOne (1noname) wrote : | #8 |
Is there some way to fix it or a workaround ?
Something I could try to help ?
Christophe C (batra3) wrote : | #9 |
2017-08-18 - Ubuntu Gnome 17.04 - meteo mix franche and english. Exemple : "Broken clouds, puis Drizzle, suivi par Overcast plus tard. Température ressentie : 22,0°C"
Changed in gnome-weather: | |
importance: | Unknown → Medium |
status: | Unknown → Confirmed |
Christophe C (batra3) wrote : | #10 |
In fact the problem is simple : libgweather-
In debian sid, libgweather-
/usr/share/
/usr/share/
/usr/share/
/usr/share/
/usr/share/
/usr/share/
.......
See here the complet list of "normals" files : https:/
In Ubuntu 17.10 and 18.04, libgweather-
I picked the 2 files which interess me in libgweather-
/usr/share/
/usr/share/
and i copied them (in root) in the same directory on my disk. And GNOME-WEATHER just Work. In french.
So please, rebuild libgweather-
Jeremy Bicha (jbicha) wrote : | #11 |
Christophe, thank for your feedback and helping to make Ubuntu better.
Ubuntu does use the same packaging for libgweather as Debian, except that Ubuntu uses language packs. There is a problem with gnome-weather not working correctly with Ubuntu language packs. This might be similar to LP: #1491787 which was just fixed upstream in GNOME.
Gunnar Hjalmarsson (gunnarhj) wrote : | #12 |
It seems to be a filename confusion. libgweather-common looks for libgweather-3.0.mo while the language packs provide libgweather.mo. It works for me on 17.10 with the version in this PPA:
https:/
It might be a way to fix it on stable releases. Going forward I suppose we should make the language packs build with the right filenames.
Jeremy Bicha (jbicha) wrote : | #13 |
Gunnar, I'll upload that to bionic to see if it works there too. (It might work in the PPA just because locales aren't stripped there).
Gunnar Hjalmarsson (gunnarhj) wrote : | #14 |
On 2017-12-08 23:38, Jeremy Bicha wrote:
> (It might work in the PPA just because locales aren't stripped
> there).
To test that I renamed
/usr/share/
to
/usr/share/
and it still found the Swedish translations. So it ought to work also when the translations are stripped.
Gunnar Hjalmarsson (gunnarhj) wrote : | #15 |
OTOH, doing so makes the source package actually name the files libgweather.mo. Maybe a better way, to not confuse Rosetta, is to change line 87 in
https:/
from
bindtextdomain (GETTEXT_PACKAGE, GNOMELOCALEDIR);
to
bindtextdomain ("libgweather", GNOMELOCALEDIR);
But that's untested.
Jeremy Bicha (jbicha) wrote : | #16 |
Gunnar, I tried the binaries from
https:/
and I still experience the bug.
tags: | added: block-proposed |
Gunnar Hjalmarsson (gunnarhj) wrote : | #17 |
On 2017-12-09 01:24, Jeremy Bicha wrote:
> Gunnar, I tried the binaries from
>
> https:/
>
> and I still experience the bug.
Those binaries fix the bug for me on bionic.
Please see attached image and compare with:
$ echo $(LANGUAGE=sv gettext -d libgweather Overcast)
Heltäckande moln
P.S. I also tested the idea to modify gweather-weather.c directly, but that did not work for me.
Jeremy Bicha (jbicha) wrote : | #18 |
Gunnar, thanks, I can confirm it works now. I guess my problem was that I tried to run LANGUAGE=fr gnome-weather instead of fully changing my locale.
Changed in gnome-weather (Ubuntu): | |
status: | In Progress → Invalid |
Changed in libgweather (Ubuntu): | |
status: | Confirmed → Fix Committed |
no longer affects: | gnome-weather (Ubuntu Artful) |
Changed in libgweather (Ubuntu Artful): | |
importance: | Undecided → High |
status: | New → Triaged |
Jeremy Bicha (jbicha) wrote : | #19 |
Gunnar, do you want to try proposing your suggestion upstream to GNOME?
tags: |
added: artful bionic l10n removed: block-proposed |
Gunnar Hjalmarsson (gunnarhj) wrote : | #20 |
On 2017-12-09 05:13, Jeremy Bicha wrote:
> Gunnar, do you want to try proposing your suggestion upstream to
> GNOME?
I doubt they would acknowledge it as an upstream thing. The issue may have been present since the porting to GTK+ 3.0 in 2010:
https:/
My theory is that the template name in LP should have been changed then from "libgweather" to "libgweather-3.0", but that did not happen.
https:/
And that may be the reason why the langpack builder keeps creating files named "libgweather.mo".
So the change may be an SRU candidate if it's considered important enough, but my belief is that the 'right' fix in 18.04+ is to change the langpacks somehow and drop the patch. And if nobody has time to do that, keeping the "hack" as an Ubuntu/Debian delta for now is another option.
Gunnar Hjalmarsson (gunnarhj) wrote : | #21 |
To be specific, I think that both the template name and translation domain should be changed to "libgweather-3.0" here:
https:/
I think I have permission to do that, but want to talk with Sebastien first.
Launchpad Janitor (janitor) wrote : | #22 |
This bug was fixed in the package libgweather - 3.26.0-1ubuntu1
---------------
libgweather (3.26.0-1ubuntu1) bionic; urgency=medium
* debian/
- Try to make libgweather-common find the translations in Ubuntu's
language packs (LP: #1704533).
-- Gunnar Hjalmarsson <email address hidden> Fri, 08 Dec 2017 22:54:00 +0100
Changed in libgweather (Ubuntu): | |
status: | Fix Committed → Fix Released |
Gunnar Hjalmarsson (gunnarhj) wrote : | #23 |
Discussed the proposal in comment #21 with Sebastien Bacher, and changed the template name and translation domain to "libgweather-3.0" in LP for bionic.
Changed in ubuntu-translations: | |
assignee: | nobody → Gunnar Hjalmarsson (gunnarhj) |
importance: | Undecided → High |
status: | New → In Progress |
description: | updated |
Changed in libgweather (Ubuntu Artful): | |
status: | Triaged → In Progress |
Gunnar Hjalmarsson (gunnarhj) wrote : | #24 |
Changed in gnome-weather: | |
status: | Confirmed → Unknown |
Gunnar Hjalmarsson (gunnarhj) wrote : | #26 |
For the record I'd like to mention that the key information to spot the root cause of this bug was provided in Christophe's comment #10, even if the solutions differ.
Thanks, Christophe, for your helpful contribution!
no longer affects: | gnome-weather (Ubuntu Xenial) |
no longer affects: | gnome-weather (Ubuntu Zesty) |
Changed in libgweather (Ubuntu Xenial): | |
status: | New → In Progress |
importance: | Undecided → High |
Changed in libgweather (Ubuntu Zesty): | |
status: | New → In Progress |
importance: | Undecided → High |
Jeremy Bicha (jbicha) wrote : | #27 |
Uploaded debdiffs to the SRU queue where they will need to be manually approved by the SRU Team before being built as proposed updates.
Hello NoOne, or anyone else affected,
Accepted libgweather into xenial-proposed. The package will build now and be available at https:/
Please help us by testing this new package. See https:/
If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-
Further information regarding the verification process can be found at https:/
Changed in libgweather (Ubuntu Xenial): | |
status: | In Progress → Fix Committed |
tags: | added: verification-needed verification-needed-xenial |
Changed in libgweather (Ubuntu Zesty): | |
status: | In Progress → Fix Committed |
tags: | added: verification-needed-zesty |
Changed in libgweather (Ubuntu Artful): | |
status: | In Progress → Fix Committed |
Chris J Arges (arges) wrote : | #29 |
Hello NoOne, or anyone else affected,
Accepted libgweather into zesty-proposed. The package will build now and be available at https:/
Please help us by testing this new package. See https:/
If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-
Further information regarding the verification process can be found at https:/
tags: | added: verification-needed-artful |
Chris J Arges (arges) wrote : | #30 |
Hello NoOne, or anyone else affected,
Accepted libgweather into artful-proposed. The package will build now and be available at https:/
Please help us by testing this new package. See https:/
If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-
Further information regarding the verification process can be found at https:/
Gunnar Hjalmarsson (gunnarhj) wrote : | #31 |
Verified the test case
- on xenial with version 3.18.2-0ubuntu0.2 from xenial-proposed
- on zesty with version 3.24.1-0ubuntu0.2 from zesty-proposed
- on artful with version 3.26.0-1ubuntu0.1 from artful-proposed
tags: |
added: verification-done verification-done-artful verification-done-xenial verification-done-zesty removed: verification-needed verification-needed-artful verification-needed-xenial verification-needed-zesty |
NoOne (1noname) wrote : | #32 |
Sorry, I can't test it...
I enabled artful-proposed.
I created a file in /etc/apt/
Package: libgweather
Pin: release a=artful-proposed
Pin-Priority: 400
But when I test it with : sudo apt-get upgrade -s
I get lots of packages to upgrade.
I guess I'm doing something wrong... Not used to do that.
Gunnar Hjalmarsson (gunnarhj) wrote : | #33 |
@NoOne: No need to mess with priority settings. Instead of running
sudo apt upgrade
run
sudo apt install gir1.2-gweather-3.0 libgweather-3-6 libgweather-common
and then disable -proposed again.
NoOne (1noname) wrote : | #34 |
@Thanks Gunnar, it worked like you said.
Can confirm that the fix works !
Finally! Very happy. :-)
Gunnar Hjalmarsson (gunnarhj) wrote : | #35 |
Thank *you*, NoOne, both for reporting the issue and for confirming the fix.
NoOne (1noname) wrote : | #36 |
Now, if someone could ever fix that bug, I would be free of any annoyance in Ubuntu. :-)
https:/
Let's hope for 18.04.
Launchpad Janitor (janitor) wrote : | #37 |
This bug was fixed in the package libgweather - 3.26.0-1ubuntu0.1
---------------
libgweather (3.26.0-1ubuntu0.1) artful; urgency=medium
* Add langpack-
- Rename the gettext template to work around Launchpad issue. This fixes
the untranslated weather conditions in the GNOME Weather app.
(LP: #1704533)
-- Gunnar Hjalmarsson <email address hidden> Mon, 11 Dec 2017 12:54:00 +0100
Changed in libgweather (Ubuntu Artful): | |
status: | Fix Committed → Fix Released |
The verification of the Stable Release Update for libgweather has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.
Launchpad Janitor (janitor) wrote : | #39 |
This bug was fixed in the package libgweather - 3.24.1-0ubuntu0.2
---------------
libgweather (3.24.1-0ubuntu0.2) zesty; urgency=medium
* Add langpack-
- Rename the gettext template to work around Launchpad issue. This
fixes the untranslated weather conditions in the GNOME Weather
app. (LP: #1704533)
-- Gunnar Hjalmarsson <email address hidden> Mon, 11 Dec 2017 20:29:00 +0100
Changed in libgweather (Ubuntu Zesty): | |
status: | Fix Committed → Fix Released |
Launchpad Janitor (janitor) wrote : | #40 |
This bug was fixed in the package libgweather - 3.18.2-0ubuntu0.2
---------------
libgweather (3.18.2-0ubuntu0.2) xenial; urgency=medium
* Add langpack-
- Rename the gettext template to work around Launchpad issue. This
fixes the untranslated weather conditions in the GNOME Weather
app. (LP: #1704533)
-- Gunnar Hjalmarsson <email address hidden> Mon, 11 Dec 2017 20:25:00 +0100
Changed in libgweather (Ubuntu Xenial): | |
status: | Fix Committed → Fix Released |
Gunnar Hjalmarsson (gunnarhj) wrote : | #41 |
On 2017-12-11 14:58, Gunnar Hjalmarsson wrote:> Discussed the proposal in comment #21 with Sebastien Bacher, and
> changed the template name and translation domain to "libgweather-3.0"
> in LP for bionic.
With version 1:18.04+20180118 of language-
Changed in ubuntu-translations: | |
status: | In Progress → Fix Released |
@Jeremy: AFAICT the strings mentioned in the bug description don't exist in the gnome-weather package. Any idea where they come from?