Comment 15 for bug 116443

The behavior goes well beyond counterintuitive and into the realms of the actively deceptive. What Emmet Caulfield omitted to mention in his excellent comment is that when you first click in folder properties to change an icon, a window opens entitled "Browse icons" which has icons in it - the current icon and all icons in the same folder. And you CAN select one of these if you wish. This establishes the expectation that the name of the game is to browse to and select icons. The user does not expect that clicking the "Browse" button in this "browse icons" window will invoke ... a folder selector. If you click a button that says "Browse" you expect to actually browse. The folder switcher itself furthers this deception by opening in a window labelled "browse" and looking and behaving exactly like a file browser except that all the folders seem to be empty. I can't see how the behavior could be more deceptive. It certainly fooled me which is how I ended up here.

The behavior is not ideal. A true browser would be better. However the deception could be easily addressed without having to change anything except the appearance of the windows which is a fairly trivial fix. I suggest the following.

1. Change the title of the button in the first window to "choose folder" instead of "BROWSE".
2. Retitle the deceptive window "choose folder" instead of "browse".
3. Add the following words to the bottom of the window in the region to the left of the cancel button (which is conveniently vacant).
CHOOSE A FOLDER TO BROWSE FOR ICONS