Comment 3 for bug 872860

Revision history for this message
Sebastien Bacher (seb128) wrote :

Today I looked the ppa version, some comments:

* the -bin binary conflicts with the previous version one because they both ship those binaries: gda-list-config gda-sql gda-list-server-op

solutions:
- use a Conflicts in the control to declare that both can't be installed at the same time
- drop the non versioned named for the non default version (i.e pick one between 4 and 5 to be default)
- use alternatives to let user select the default version (it's a bit harder to handle from the packaging and user sides)

* the -dev and -doc binaries conflict because they both ship Gda-5.0.gir

* libgda-5.0-common.preinst doesn't seem required, it seems a "clean on upgrade" leftover from the previous series due to a packaging error by then.

* libgda-5.0-doc.doc-base.libgda4-reference

shouldn't the filename and title be updated gda4->gda5

Otherwise the update looks fine. I would welcome a comment with your upstream view on the conflicts question.
Do you want to fix those issues and submit a new package or do you prefer us to deal with fixing and uploading and giving you a diff showing what we changed? Out of the conflict issue which needs a bit of thinking the others are trivial to do and I'm happy to do it for you

Note that I would also welcome your upstream opinion on the configure options used in the rules. Would it be better if we did enable the ui option later in another upload? What would it add, and is there anything needed it? That seems like it would require extra packaging change so better to get the update in first and do iterative tweaks later