Comment 5 for bug 2030880

Revision history for this message
Miriam EspaƱa Acebal (mirespace) wrote (last edit ):

Hi Lukas! Thank you for the review of the patch and the remarks.

I open an issue on upstream forwarding the patch for the refactor: https://github.com/msimerson/mail-dmarc/issues/216 .

I didn't realize I left 2 eml files for the tests on /d/t/data ... thankyou! I erased them . All the rest on data/nice and data/spam are taken from spamassassin tests itself, so I think we are good with them (at least, as good as spamassassin).

I'll correct the indentation, sorry for this.

Thanks again for helping me to polish the package's changes.