Comment 4 for bug 2030880

Revision history for this message
Lukas Märdian (slyon) wrote :

I'm not an expert on Perl code, but your patch in d/p/use-MIME-Entity-and-MIME-Parser-from-libmime-tools-p.patch LGTM!

Unfortunately, we don't have an autopkgtest baseline (libmail-dmarc-perl didn't have any autopkgtests before). But I like seeing new ones being added.

We do have a baseline of build-time tests in dh_auto_test, though, which looks very promissing, as everything passes, as before:
```
All tests successful.
Files=20, Tests=652, 5 wallclock secs ( 0.08 usr 0.01 sys + 4.06 cusr 0.42 csys = 4.57 CPU)
Result: PASS
```

Some general remarks on your "noble-splitting-dependencies" branch:
* debian/control has some whitespace/indentation issues on the new dependencies (tabs vs spaces?)
* Take care not to leak personal data (email address) in d/t/data/ -- This will be public information and spam bots might parse it (ironically for the spam filter tests ;-))
* Have you considered proposing your changes/patch to upstream libmail-dmarc-perl? Considering that there's little maintainer or upstream activity on the bug report in #3 they might be interested in switching away from those dependencies, too. We should not block on this, but maybe it could be forwarded in parallel, to get some additional input on the perl patch.

I'll be marking this MIR bug report as WONTFIX, since we're moving towards #2 (MIME::Parser and MIME::Entity). It can be re-opened should this approach change.