Comment 23 for bug 618587

Revision history for this message
Michael Terry (mterry) wrote :

OK. Here's a brain dump. There are several issues with eclipse:
1) Menu items (including toplevel entries) don't appear
2) Some menu items (especially the first in a menu) have the text "Label Empty" instead of real text
3) Accelerators (keyboard shortcuts) are not shown
4) When eclipse wants to change its toplevel entries, that isn't reflected in the appmenu

#1 and #2 can be mostly fixed by showing the menu items as they come in, like I mention in the previous comment.

#2 can be partly fixed by handling how SWT apps handle accelerators (they use deprecated direct access to label structs to set the visible shortcut, then go and separately set the accelerator for the menu item directly). I have a fix for this [1]. But most of eclipse's menu items also don't even pass the accelerator to gtk. They directly set the visible string, but don't set the accelerator on the gtk menu item at all, handling them itself. This needs either a patch to eclipse or a plugin or something. I haven't quite figured where this patch needs to be, but I believe it might be in eclipse/plugins/org.eclipse.jface/src/org/eclipse/jface/action/ActionContributionItem.java.

#3 I haven't been able to track down. It is passing the items to indicator-appmenu correctly, but the items are never "realized". This is very similar to what I was seeing with #1, so I'm probably just not 'showing/hiding' in the right place.

In summation, I don't believe this is a good use of time for natty. Best for oneiric.

[1] https://code.launchpad.net/~mterry/dbusmenu/check-gmi-for-accel-closures/+merge/54230