Comment 42 for bug 2003259

Revision history for this message
Sebastien Bacher (seb128) wrote :

@libcupsfilters

The MIR review feedback was

> Required TODOs:
> - The autopkgtests is marked as superficial, and indeed, when looking at what is done, it builds the lib and call a logging function in it.
> For packages in main, we need non trivial autopkgtests. As this package is doing quite a lot, we need to get to a higher standard
> and improve the autopkgtests suite.

It was fixed in https://launchpad.net/ubuntu/+source/libcupsfilters/2.0~b4-0ubuntu1
Till added a libcupsfilters-tests binary including the same checks as the upstream testsuite and is using them as autopkgtests now
https://autopkgtest.ubuntu.com/packages/lib/libcupsfilters

> - Remember to subscribe the desktop-packages team as I think it will be the official team owning the packages so that list of criticals bugs can be adressed.

desktop-packages subscribed now

> Recommended TODOs:
> - There are a lot of warnings during the build. This makes the build process hard to read if a new error occur and it’s a nice opportunity to fix them upstream and downstream.

Till fixed some of the warnings upstream now.
@Till, should we also set CXXFLAGS='-DPOINTERHOLDER_TRANSITION=0' as you said it would help cut some of the remaining noise?

Security team also gave a +1 for promotion.

Since there is no remaining blocker item I'm promoting libcupsfilters now