Comment 61 for bug 61303

Revision history for this message
In , Brian-cameron-oracle (brian-cameron-oracle) wrote :

Created an attachment (id=9844)
updated patch for cairo 1.4.6

I noticed that the latest version of this patch is for cairo 1.4.2 and apply against cairo 1.4.6. The code is pretty much the same, though the structures have now moved into cairo-xlib-surface-private.h.

I notice when I log into my session passing "-depth 8" to the Xorg Xserver, so I am running in 8bit mode that there are some problems:

- sometimes the background image doesn't look right. Depending on the
  background image used, it looks like it isn't being scaled cleanly or it
  sometimes has horizontal black lines running through the image.
- I also notice that gnome-screenshot seems to take really messed up pictures
  of the desktop.

So I'm not sure 8bit mode works perfectly even with this patch applied, though those bugs may not be related to cairo. I'm not sure. I see the exact same problems running with the earlier version of the patch with cairo 1.4.0, so I do not think these problems are introduced by my update of the patch.

I haven't filed bugs against these two issues yet since this 8bit logic isn't yet integrated into cairo. I just mention I am seeing these problems so the cairo developers can look into this and see if they might understand what the problems may be. If these aren't cairo problems, we probably should file bugs against control-center Desktop Background capplet and gnome-screenshot once this patch goes upstream.