Comment 10 for bug 899183

Revision history for this message
Andrew Starr-Bochicchio (andrewsomething) wrote :

A couple comments.

1) In debian/rules, you run rm -f $(DEB_DESTDIR)/usr/share/pyshared/libavg/avg.la in the debian/stamp-install%: target. This isn't actually removing the .la file. It's still in the resulting deb.

The following lintian error is produced:

E: python-libavg: non-empty-dependency_libs-in-la-file usr/share/pyshared/libavg/avg.la
N:
N: The dependency_libs field in the .la file has not been cleared. It has
N: long been a release goal to get rid of unneeded .la files and clearing
N: the dependency_libs field from the rest of them.
N:
N: A non-empty dependency_libs field will also stall the Multi-Arch
N: conversion.
N:
N: The .la file in itself may be useful, if the library is loaded
N: dynamically via libltdl.
N:
N: Refer to http://wiki.debian.org/ReleaseGoals/LAFileRemoval,
N: http://lists.debian.org/debian-devel/2011/05/msg01003.html, and
N: http://lists.debian.org/debian-devel/2011/05/msg01146.html for details.
N:
N: Severity: serious, Certainty: certain

2) You seem to be using dh_python2, but you still build-depend on python-central. Also you don't need debian/pycompat. See http://wiki.debian.org/Python/TransitionToDHPython2

3) This lintian warning is also produced:

W: python-libavg: debian-changelog-line-too-long line 2
N:
N: The given line of the latest changelog entry is over 80 columns. Such
N: changelog entries may look poor in terminal windows and mail messages
N: and be annoying to read. Please wrap changelog entries at 80 columns or
N: less where possible.
N:
N: Severity: normal, Certainty: certain
N:
N: Check: changelog-file, Type: binary
N: