Comment 14 for bug 1029549

Revision history for this message
Michael Terry (mterry) wrote :

For signon-plugin-oauth2, it looks mostly fine. Love the tests! No blockers, but I do have some questions.

Questions:
Why is libqtwebkit-dev a Build-Dependency? It didn't look like it was used.
Why is there a tests package in debian/control? Seems like that's not something users would want to install, vs just being a part of the build.

Nits:
Maintainer should be "Ubuntu Developers <email address hidden>"
Debhelper 9 would be nice.

Passing off to security team for a quick review of the oauth1 and oauth2 implementations. Not sure if it's needed, but better safe than sorry.