Comment 9 for bug 1349920

Revision history for this message
Robie Basak (racb) wrote :

Looks good. Uploaded to Trusty - thank you for preparing this. Now awaiting SRU team review.

A few really minor review comments. I changed the version from 0.79-0.2ubuntu1 to 0.79-0.2ubuntu0.1. Following the scheme at https://wiki.ubuntu.com/SecurityTeam/UpdatePreparation#Update_the_packaging just makes it really clear it's an SRU, and avoids any potential conflict with Utopic, though that couldn't happen in this case. I ran "update-maintainer" to fix the Maintainer field (https://wiki.ubuntu.com/DebianMaintainerField). And finally, even more minor, in the dep3 headers, "Origin: upstream, <url>" makes it clearer if upstream has committed the patch at the time of writing. But "Forwarded:" is also fine, so I haven't changed it.