Comment 17 for bug 250935

Revision history for this message
Tormod Volden (tormodvolden) wrote :

Alexey, I totally agree, doing it like you did was the best way. Change code first, preserving behaviour, and then flip the configuration settings later. I just forgot about that setting being in this patch.

We must be careful to avoid regressions. laptop-mode-tools used to be an add-on package, later become installed by default, but disabled. for a reason or many. But maybe these reasons are not valid any longer. Anyway, changing power and disk settings is always controversial.

About ENABLE_LAPTOP_MODE, I commented on this in bug #244838 - I think that's the right place for that discussion. We have spread things out in way too many bug reports maybe :)

One difference with Debian is that there, people install the package because they want it, and uninstall it if it doesn't work well. On Ubuntu, we ship it to everybody, and it must Just Work.