Comment 5 for bug 1772237

Revision history for this message
Ɓukasz Zemczak (sil2100) wrote :

I was actually hesitating whether or not it makes sense to get this fix into bionic. Yes, the fix is legit and I think this is how it should be in language-selector from the beginning - an invalid locale string should not cause a crash but should be handled as you proposed. I was a bit worried since I think we anyway need to get localechooser fixed, as this fix here will only eliminate the crash - certain new locales still won't work as they should because of the missing codeset component. And every update carries a risk, so potentially we'd like to avoid unnecessary updates.

But... I decided that in this case we should just do it. I might pick up and get localechooser do the right thing, but language-selector binaries are anyway quite small and who knows when we'll encounter the issue again.