Comment 70 for bug 124987

Revision history for this message
In , Dmitry V. Levin (ldv) wrote :

Well, I have to comment on this finally.

First of all, the patch that was actually applied (http://git.altlinux.org/gears/g/..git?p=glibc.git;a=commitdiff;h=glibc-2.13-145-gf498392) does something very different from its description (Lowercase month names). Besides the change of abbreviated month names to lowercase (which is probably OK), it also slipped in a mix of other changes:
- change of abbreviated day names from fixed three-letter form to fixed two-letter form (actually fixes http://sourceware.org/bugzilla/show_bug.cgi?id=10873 which provides a good set of references);
- unjustified addition of trailing dots to abbreviated day names (it's plain wrong);
- unjustified addition of trailing dots to abbreviated month names (it's also plain wrong);
- unjustified change of abbreviated month names from nominative to genitive (it's also wrong and it actually reverts the fix made for http://sourceware.org/bugzilla/show_bug.cgi?id=525);
- unjustified change of abbreviated month names from fixed three-letter form to variable length form (just a nonsense).

Second, the procedure of describing changes, getting an approval from the locale maintainer and providing good references (as described in http://sourceware.org/glibc/wiki/Contribution%20checklist#Qualification_.28Locales.29) was totally scrapped.

What I suggest in the way of recovery is to revert all these unjustified changes. The only changes that can remain are:
- change of abbreviated month names to lowercase (a fix for this bug report);
- change of abbreviated day names to two-letter form (a fix for http://sourceware.org/bugzilla/show_bug.cgi?id=10873).