© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
Hello and thanks for preparing the upload. A couple of comments:
* The quilt patch is not excellent. It includes changes that were not part of the upstream commit [1] that fixes the FTBFS. The changes are not harmful but they make the patch "dirty".
* The dep-3 headers are not fully correct. The patch comes from upstream, so we should have "Origin: upstream, <link>", and not Applied-Upstream.
I see that these issue are directly inherit from Debian (1.1.2-2). From one side keeping the patch identical to what we have in the Ubuntu devel release (and Debian) is nice, but I think the SRU team will prefer a clean patch only touching what's necessary.
Now one comment on the d/changelog entry you added for this change. You mention that the patch is a "backport", which makes me think that you somehow adapted the Debian patch, while this is not the case, it is taken as-is. Please consider rewording (perhaps using dep3changelog).
If you agree with these comments, could you please update your debdiff accordingly?
Also please note that the upload will likely be staged [2], as it is low priority.
Thanks!
[1] https:/
[2] https:/