Comment 28 for bug 1697501

Revision history for this message
Eric Desrochers (slashd) wrote :

Hi Łukasz Zemczak (sil2100),

With regard to the basic sanity-spin of the new ksh for each of the other stable series to make sure those are not completely broken.

I have tested ksh against a number of regression tests offered in the ksh source package itself.

--
To run all these tests with the shell you just built, go to the tests directory and run the command:
SHELL=$dir/ksh $dir/ksh shtests
where dir is the directory of the ksh you want to test.
--

The output the regression tests are generating is very long, but to summarize it test the binary in depth. Testing alias, append, arrays, attributes, bracket, enum, exit, expand, functions, grep, io, leaks, locale, math, namespace, path, options, quoting sigchld, signal, variables, tilde, and many more.

Output example :

test sigchld passed at 2017-07-18+15:31:19 [ 14 tests 0 errors ]
test sigchld(C.UTF-8) begins at 2017-07-18+15:31:19
test sigchld(C.UTF-8) passed at 2017-07-18+15:31:35 [ 14 tests 0 errors ]
test sigchld(shcomp) begins at 2017-07-18+15:31:35
test sigchld(shcomp) passed at 2017-07-18+15:31:50 [ 14 tests 0 errors ]

I'm showing this above regression test output as an example and because the bug was about a segfault after receiving a sigchld.

I won't hide that the test is sometime generating errors here and there, even if the huge majority of the regression tests passed without errors. Amongst the reported errors I can't find anything obvious that could be related to the patch I have submitted.

I have strong believe these errors existed pre-SRU, and are probably there for a while, since there is no new development nowadays for ksh project.

Example of errors :
test bracket(C.UTF-8) begins at 2017-07-18+15:27:58
 bracket.sh[86]: -r: /tmp/tmp.HapRrWwjIk/original should not be readable
 bracket.sh[92]: -w: /tmp/tmp.HapRrWwjIk/original should not be writable
 bracket.sh[95]: -x: /tmp/tmp.HapRrWwjIk/original should not be executable
 bracket.sh[98]: -rw: /tmp/tmp.HapRrWwjIk/original should not be readable/writable
test bracket(C.UTF-8) failed at 2017-07-18+15:28:03 with exit code 1 [ 118 tests 1 error ]

Hope the above verification is enough for you to have confidence in the -proposed package for X/Y/Z.

- Eric