Comment 2 for bug 1331320

Revision history for this message
Hamilton Turner (hamiltont-x) wrote :

I believe http://bazaar.launchpad.net/~hamiltont-x/kickseed/kickseed/revision/298 addresses this well. I decided that using $RET was a poor choice, as it only checks the return of the kickseed function and can return a 0 value even if an internal function returns a non-zero value. I have instead disabled errexit when running test-kickseed and added a trap for catching ERR signals. This allows us to output a nice warning message that the installation will not work as expected because there was an ERR triggered while parsing the kickstart. Note: I used code from http://stackoverflow.com/q/6928946/119592, so if the licensing isn't ok then we may need to rewrite the ERR handler from scratch. If this is necessary someone let me know, it's only a few lines but the one I used is fairly comprehensive